Skip to content

FINERACT-2827: Document missing tax component fields - #6453

Open
shubhamchaudhary29 wants to merge 1 commit into
apache:developfrom
shubhamchaudhary29:FINERACT-2827-openapi-tax-debit-fields
Open

shubhamchaudhary29 wants to merge 1 commit into
apache:developfrom
shubhamchaudhary29:FINERACT-2827-openapi-tax-debit-fields

Conversation

@shubhamchaudhary29

@shubhamchaudhary29 shubhamchaudhary29 commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Description

The tax component API response contains debitAccountType and debitAccount, but these fields were missing from the OpenAPI/Swagger response documentation.

I added the missing fields to the Swagger response model.

Changes

  • Added debitAccountType to the response schema
  • Added debitAccount to the response schema
  • Added the required fields for both objects
  • Regenerated the OpenAPI specification

Testing

  • Spotless check passed
  • Java compilation passed
  • OpenAPI generation passed
  • Verified that the generated OpenAPI schema contains the two new fields

Checklist

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.
  • I followed the AI Policy.

@adamsaghy

Copy link
Copy Markdown
Contributor

@shubhamchaudhary29 Please make sure your commits are GPG signed

@shubhamchaudhary29
shubhamchaudhary29 force-pushed the FINERACT-2827-openapi-tax-debit-fields branch from 1b5384e to 8d34e89 Compare September 16, 2026 13:36
@shubhamchaudhary29

Copy link
Copy Markdown
Contributor Author

@adamsaghy , i signed this commit, please approve the workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants