Skip to content

FINERACT-2455: WC - Add missing permissions for transaction undo and charge creation - #6449

Draft
oleksii-novikov-onix wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2455/wc-missing-command-permissions
Draft

oleksii-novikov-onix wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2455/wc-missing-command-permissions

Conversation

@oleksii-novikov-onix

Copy link
Copy Markdown
Contributor

Description

Undoing a Working Capital loan transaction and adding a charge to a Working Capital loan both check permission codes that have no row in m_permission, so only a super user can run them. Transaction undo also had a typo in its entity constant, which made the checked code UNDO_ENTITY_WORKINGCAPITALLOANTRANSACTION.

  1. Fixed the entity constant value to WORKINGCAPITALLOANTRANSACTION.
  2. Seeded UNDO_WORKINGCAPITALLOANTRANSACTION, CREATE_WORKINGCAPITALLOANCHARGE and CREATE_WORKINGCAPITALLOANCHARGE_CHECKER, all in grouping transaction_loan.
  3. Added e2e scenarios: a non-super user holding the permission can undo a repayment and add a charge; without the undo permission the request is rejected with 403.
  4. Updated the recovery payment and charges docs.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.
  • I followed the AI Policy.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@oleksii-novikov-onix
oleksii-novikov-onix force-pushed the FINERACT-2455/wc-missing-command-permissions branch 2 times, most recently from a3660b1 to 5f3a8a4 Compare September 16, 2026 13:46
@oleksii-novikov-onix
oleksii-novikov-onix force-pushed the FINERACT-2455/wc-missing-command-permissions branch from 5f3a8a4 to 8fbea6b Compare September 16, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant