Skip to content

FINERACT-2834: Expose the originating client charge ID on client payment transactions - #6447

Open
rhopman wants to merge 1 commit into
apache:developfrom
symbaglobal:FINERACT-2834-expose-client-charge-id
Open

rhopman wants to merge 1 commit into
apache:developfrom
symbaglobal:FINERACT-2834-expose-client-charge-id

Conversation

@rhopman

@rhopman rhopman commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

This change exposes clientChargeId in client transaction API responses. The existing SQL query already retrieves the originating client charge ID, but the row mapper previously discarded it before constructing ClientTransactionData.

The existing client transaction integration test now verifies that a charge-payment transaction returns the ID of the client charge it paid. This allows consumers to correlate payments with exact client charges without relying on names, amounts, or other potentially ambiguous attributes.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.
  • I followed the AI Policy.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant