FINERACT-2455: WC - No accruals in case no accounting is configured - #6440
Draft
oleksii-novikov-onix wants to merge 1 commit into
Draft
oleksii-novikov-onix wants to merge 1 commit into
oleksii-novikov-onix wants to merge 1 commit into
Conversation
oleksii-novikov-onix
force-pushed
the
FINERACT-2455/wc-no-accruals-without-accounting
branch
from
September 14, 2026 11:31
bf98306 to
6874513
Compare
oleksii-novikov-onix
force-pushed
the
FINERACT-2455/wc-no-accruals-without-accounting
branch
from
September 16, 2026 14:19
6874513 to
bd41cb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Description:
When a Working Capital product has no accounting (NONE), accruals and accrual adjustments should not be created, but discount fee amortization and amortization adjustments should.
Already in develop:
This PR adds:
Two remaining places could reach accounting code without checking whether the product has accounting. Both now check it, which matches how regular loans behave.
E2E tests for the cases that had no coverage for products without accounting:
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.