Skip to content

FINERACT-2455: WC - No accruals in case no accounting is configured - #6440

Draft
oleksii-novikov-onix wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2455/wc-no-accruals-without-accounting
Draft

oleksii-novikov-onix wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2455/wc-no-accruals-without-accounting

Conversation

@oleksii-novikov-onix

Copy link
Copy Markdown
Contributor

Description

Description:

When a Working Capital product has no accounting (NONE), accruals and accrual adjustments should not be created, but discount fee amortization and amortization adjustments should.

Already in develop:

  1. Accruals and accrual adjustments are not created for products without accounting.
  2. Amortization and amortization adjustments are created. Only their journal entries depend on accounting.

This PR adds:

  1. Two remaining places could reach accounting code without checking whether the product has accounting. Both now check it, which matches how regular loans behave.

    • Undo of a discount fee adjustment: accounting code could block it when accounting for the office was closed for the current date, even though the loan has no journal entries.
    • Undo disbursal: no visible difference for these loans, since accruals are not created without accounting. The check keeps the rule consistent.
  2. E2E tests for the cases that had no coverage for products without accounting:

    • amortization adjustment and its undo while accounting is closed;
    • real-time accrual and undo disbursal;
    • accrual on loan closure;
    • final amortization on charge-off.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.
  • I followed the AI Policy.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@oleksii-novikov-onix
oleksii-novikov-onix force-pushed the FINERACT-2455/wc-no-accruals-without-accounting branch from bf98306 to 6874513 Compare September 14, 2026 11:31
@oleksii-novikov-onix
oleksii-novikov-onix force-pushed the FINERACT-2455/wc-no-accruals-without-accounting branch from 6874513 to bd41cb4 Compare September 16, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant