Skip to content

FINERACT-2455: Working Capital - Undo disbursement and discount fix#5902

Draft
somasorosdpc wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2455/working-capital-disbusement-and-discount-hadling-fix
Draft

FINERACT-2455: Working Capital - Undo disbursement and discount fix#5902
somasorosdpc wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2455/working-capital-disbusement-and-discount-hadling-fix

Conversation

@somasorosdpc
Copy link
Copy Markdown
Contributor

@somasorosdpc somasorosdpc commented May 28, 2026

Description

  • if WC loan product has defined discount value, e.g. 50 and disallow attributes(discount) override setting
    ** Apply
    *** during loan account application default discount is set as proposed discount
    *** after creation loan details has correct proposed discount field value
    ** Approve
    *** approve loan template should contain this value and new value to disable UI field
    *** approval with provided 50 discount or null should result as approve the default 50 for loan
    *** after approval loan details has correct approved discount field value
    ** Disburse
    *** disburse loan template should contain this value and new value to disable UI field
    *** disburse with provided 50 discount or null should result to have discount fee transaction created with the default 50 for loan

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@somasorosdpc somasorosdpc changed the title FINERACT-2455: Working Capital - Undo disbursement and discount is no… FINERACT-2455: Working Capital - Undo disbursement and discount fix May 28, 2026
Copy link
Copy Markdown
Contributor

@galovics galovics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@somasorosdpc somasorosdpc force-pushed the FINERACT-2455/working-capital-disbusement-and-discount-hadling-fix branch from f0373be to e7dc573 Compare May 28, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants