FINERACT-2293: Migrate client address module to new command pipeline#5657
Open
avivijay19 wants to merge 1 commit intoapache:developfrom
Open
FINERACT-2293: Migrate client address module to new command pipeline#5657avivijay19 wants to merge 1 commit intoapache:developfrom
avivijay19 wants to merge 1 commit intoapache:developfrom
Conversation
vidakovic
reviewed
Mar 20, 2026
| private final ClientRepositoryWrapper clientRepositoryWrapper; | ||
| private final AddressRepository addressRepository; | ||
| private final ClientAddressRepositoryWrapper clientAddressRepositoryWrapper; | ||
| private final AddressCommandFromApiJsonDeserializer fromApiJsonDeserializer; |
Contributor
There was a problem hiding this comment.
Non of these manual JSON parsing allowed. That's why we do this in the first place... to get rid of this and have proper types.
vidakovic
reviewed
Mar 20, 2026
| return address; | ||
| } | ||
|
|
||
| private Address createAddress(JsonObject jsonObject) { |
Contributor
There was a problem hiding this comment.
Nope, see previous comment... non of this "JsonObject" stuff can happen here (or anywhere).
vidakovic
reviewed
Mar 20, 2026
| @RequestBody(required = true, content = @Content(schema = @Schema(implementation = ClientAddressRequest.class))) | ||
| @ApiResponse(responseCode = "200", description = "OK", content = @Content(schema = @Schema(implementation = ClientAddressApiResourcesSwagger.PostClientClientIdAddressesResponse.class))) | ||
| public CommandProcessingResult addClientAddress(@QueryParam("type") @Parameter(description = "type") final long addressTypeId, | ||
| @ApiResponse(responseCode = "200", description = "OK", content = @Content(schema = @Schema(implementation = ClientAddressCreateResponse.class))) |
Contributor
There was a problem hiding this comment.
I am working with the authors of the compatibility checks to solve this. This annotation needs to go.
vidakovic
reviewed
Mar 20, 2026
| resilience4j.retry.instances.commandInterestRateChartSlabsDelete.exponential-backoff-multiplier=${FINERACT_COMMAND_INTEREST_RATE_CHART_SLABS_DELETE_RETRY_EXPONENTIAL_BACKOFF_MULTIPLIER:2} | ||
| resilience4j.retry.instances.commandInterestRateChartSlabsDelete.retryExceptions=${FINERACT_COMMAND_INTEREST_RATE_CHART_SLABS_DELETE_RETRY_EXCEPTIONS:org.springframework.dao.ConcurrencyFailureException,org.eclipse.persistence.exceptions.OptimisticLockException,jakarta.persistence.OptimisticLockException,org.springframework.orm.jpa.JpaOptimisticLockingFailureException} | ||
|
|
||
| resilience4j.retry.instances.commandClientAddressCreate.max-attempts=${FINERACT_COMMAND_CLIENT_ADDRESS_CREATE_RETRY_MAX_ATTEMPTS:3} |
Contributor
There was a problem hiding this comment.
Please add this a bit higher... where the other blocks of the other packages are... this last section is for the "fineract-command" module itself. So let's keep the things together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.