FINERACT-1897: Fix NPE when requestedShares is null during share acco…#5652
Open
SamaSVM wants to merge 1 commit intoapache:developfrom
Open
FINERACT-1897: Fix NPE when requestedShares is null during share acco…#5652SamaSVM wants to merge 1 commit intoapache:developfrom
SamaSVM wants to merge 1 commit intoapache:developfrom
Conversation
c5c8f65 to
367ee14
Compare
367ee14 to
40d49f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Null Long unboxing in arithmetic comparison (
requestedShares < minimumClientShares) caused NPE before the validation error list was checked, returning HTTP 500 instead of HTTP 400. Added null guard on both min/max comparisons so validation completes normally and the client receives a proper 400 response.Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.