feat: registered EscapeHexCellWriteHandler in DefaultWriteHandlerLoader for XLSX - #1044
feat: registered EscapeHexCellWriteHandler in DefaultWriteHandlerLoader for XLSX#1044delei wants to merge 8 commits into
Conversation
- Moved EscapeHexCellWriteHandler to handler.impl package - Registered EscapeHexCellWriteHandler in DefaultWriteHandlerLoader for XLSX format - Updated XlsxEscapeUtils documentation to link to EscapeHexCellWriteHandler - Improved handling of XLSX character escapes in cell writing process
- Add EscapeHexCellWriteHandlerRoundTripTest to verify hex escapes on write are read back literally - Remove redundant HexEscapeRoundTripTest which tested similar functionality - Import EscapeHexCellWriteHandler where necessary in write handler tests - Ensure round trip correctness for cells containing hexadecimal escape patterns in data fields
|
You should also probably update the comment in |
|
Not sure if you considered this already, but the handler isn't idempotent, so this PR affects the users who already register the handler themselves. Therefore, maybe it'd be good to make sure the handler can only take effect once per value. |
A very good point. Thank you for pointing out the issue. I have corrected this. This handler really should ensure that you only execute it once. |
Purpose of the pull request
Closed: #850
What's changed?
EscapeHexCellWriteHandlertoorg.apache.fesod.sheet.write.handler.implpackageEscapeHexCellWriteHandlerinDefaultWriteHandlerLoaderfor XLSX format.Checklist