Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
|
Thanks, @kwy404 ! The fix is exactly as I proposed, and I think the test is high quality. I like how this can be an automated code test rather than a visual image-comparison test. Thanks again for your implementation 😃 |
Author
|
Thanks @martinburch, and thanks for the clear analysis in the issue, it made the fix straightforward. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Makes radar symbols travel out from the center together with the line and area on the entry animation, as they did in 4.x.
Fixed issues
Details
Before: What was the problem?
Root cause: in the
addbranch ofRadarView,graphic.initProps(polyline, target, ...)runs beforeupdateSymbols(polyline.shape.points, ...). Since 5.x,initPropsanimates withsetToFinal: true, so it already writes the final shape onto the element, sopolyline.shape.pointsholds the target points by the timeupdateSymbolsreads it. Each symbol is therefore placed at its final position and animated from there to the same position, so it shows up at the end point on the first frame while the line grows from the center.After: How does it behave after the fixing?
Fix: pass
getInitialPoints(points)(the radar center for every point, the same start used for the polygon and polyline) as the start points toupdateSymbolsinstead of reading them back from the polyline. The update path is unchanged.Test: added
test/ut/spec/series/radar.test.ts, which renders a radar series with the default animation and checks that the first symbol starts at the radar center[200, 200]. It fails before the fix (received[200, 100], the final point) and passes after it.Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Merging options
Other information
The reproduction from the issue: https://codepen.io/martinburch/pen/pveWoEy