Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/component/visualMap/PiecewiseModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,13 @@ class PiecewiseModel extends VisualMapModel<PiecewiseVisualMapOption> {
? piece.value + '' : piece.index + '';
}

/**
* @override
*/
isCategoryMode(): boolean {
return this._mode === 'categories';
}

/**
* @public
*/
Expand Down Expand Up @@ -313,9 +320,14 @@ class PiecewiseModel extends VisualMapModel<PiecewiseVisualMapOption> {
const dataIndices: number[] = [];
const data = seriesModel.getData();

data.each(this.getDataDimensionIndex(data), function (value: number, dataIndex: number) {
const dimIndex = this.getDataDimensionIndex(data);
const ordinalMeta = this.isCategoryMode() && data.getStore().getOrdinalMeta(dimIndex);

data.each(dimIndex, function (value: number, dataIndex: number) {
// Should always base on model pieceList, because it is order sensitive.
const pIdx = VisualMapping.findPieceIndex(value, pieceList);
const pIdx = VisualMapping.findPieceIndex(
(ordinalMeta ? ordinalMeta.categories[value] : value) as number, pieceList
);
pIdx === pieceIndex && dataIndices.push(dataIndex);
}, this);

Expand Down
7 changes: 7 additions & 0 deletions src/component/visualMap/VisualMapModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,13 @@ class VisualMapModel<Opts extends VisualMapOption = VisualMapOption> extends Com
return null;
}

/**
* Whether data values on an ordinal dimension are matched by their category strings.
*/
isCategoryMode(): boolean {
return false;
}

/**
* FIXME
* Do not publish to thirt-part-dev temporarily
Expand Down
3 changes: 2 additions & 1 deletion src/component/visualMap/visualEncoding.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ export const visualMapEncodingHandlers: StageHandler[] = [
visualMapModel.stateList,
visualMapModel.targetVisuals,
zrUtil.bind(visualMapModel.getValueState, visualMapModel),
visualMapModel.getDataDimensionIndex(seriesModel.getData())
visualMapModel.getDataDimensionIndex(seriesModel.getData()),
visualMapModel.isCategoryMode()
));
});

Expand Down
17 changes: 13 additions & 4 deletions src/visual/visualSolution.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,11 @@ import {
ParsedValue,
DimensionLoose,
StageHandlerProgressExecutor,
DimensionIndex
DimensionIndex,
OrdinalNumber
} from '../util/types';
import SeriesData from '../data/SeriesData';
import OrdinalMeta from '../data/OrdinalMeta';
import { getItemVisualFromData, setItemVisualFromData } from './helper';

const each = zrUtil.each;
Expand Down Expand Up @@ -195,12 +197,14 @@ export function applyVisual<VisualState extends string, Scope>(
* @param visualMappings <state, Object.<visualType, module:echarts/visual/VisualMapping>>
* @param getValueState param: valueOrIndex, return: state.
* @param dim dimension or dimension index.
* @param useCategory map ordinal numbers on `dim` back to their category strings.
*/
export function incrementalApplyVisual<VisualState extends string>(
stateList: readonly VisualState[],
visualMappings: VisualMappingCollection<VisualState>,
getValueState: (valueOrIndex: ParsedValue | number) => VisualState,
dim?: DimensionLoose
dim?: DimensionLoose,
useCategory?: boolean
): StageHandlerProgressExecutor {
const visualTypesMap: Partial<Record<VisualState, BuiltinVisualProperty[]>> = {};
zrUtil.each(stateList, function (state) {
Expand All @@ -210,9 +214,12 @@ export function incrementalApplyVisual<VisualState extends string>(

return {
progress: function progress(params, data) {
const store = data.getStore();
let dimIndex: DimensionIndex;
let ordinalMeta: OrdinalMeta;
if (dim != null) {
dimIndex = data.getDimensionIndex(dim);
ordinalMeta = useCategory && store.getOrdinalMeta(dimIndex);
}

function getVisual(key: string) {
Expand All @@ -224,7 +231,6 @@ export function incrementalApplyVisual<VisualState extends string>(
}

let dataIndex: number;
const store = data.getStore();
while ((dataIndex = params.next()) != null) {
const rawDataItem = data.getRawDataItem(dataIndex);

Expand All @@ -234,9 +240,12 @@ export function incrementalApplyVisual<VisualState extends string>(
continue;
}

const value = dim != null
let value: ParsedValue = dim != null
? store.get(dimIndex, dataIndex)
: dataIndex;
if (ordinalMeta) {
value = ordinalMeta.categories[value as OrdinalNumber];
}

const valueState = getValueState(value);
const mappings = visualMappings[valueState];
Expand Down
80 changes: 80 additions & 0 deletions test/ut/spec/component/visualMap/piecewiseCategories.test.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.