Fix #16397: return 503 (UNAVAILABLE) instead of 404 (UNIMPLEMENTED) w… - #16398
Open
LI123456mo wants to merge 2 commits into
Open
Fix #16397: return 503 (UNAVAILABLE) instead of 404 (UNIMPLEMENTED) w…#16398LI123456mo wants to merge 2 commits into
LI123456mo wants to merge 2 commits into
Conversation
…TED) when path resolution fails during graceful shutdown
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16398 +/- ##
============================================
- Coverage 60.87% 60.87% -0.01%
+ Complexity 11766 11762 -4
============================================
Files 1953 1953
Lines 89273 89278 +5
Branches 13473 13474 +1
============================================
+ Hits 54346 54347 +1
- Misses 29333 29337 +4
Partials 5594 5594
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #16397.
Problem
When
pathResolver.resolve()fails to find an invoker because it wasunregistered during graceful shutdown,
GrpcRequestHandlerMappingthrowsa 404, which maps to gRPC
UNIMPLEMENTED. Consumer-side cluster faulttolerance treats
UNIMPLEMENTEDas a permanent, non-retriable error, soit never fails over to another provider instance — turning a routine
rolling restart into a business-visible error.
Fix
When resolution fails specifically because the application is stopping
(
ApplicationDeployer#isStopping()), return 503 instead of 404, whichmaps to gRPC
UNAVAILABLE— a retriable status consumers already knowhow to fail over on.
Testing
Added
GrpcRequestHandlerMappingTest#returnsServiceUnavailableWhenStoppingAndInvokerNotFound,verifying a 503 is thrown when the app is stopping and resolution fails.