Skip to content

branch-4.1: [fix](iceberg) Avoid BE abort on partition predicates #66835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suxiaogang223 wants to merge 1 commit into
base: branch-4.1
Choose a base branch
from
+13 −2
Open

branch-4.1: [fix](iceberg) Avoid BE abort on partition predicates #66835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions be/src/format/table/table_format_reader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,8 @@ class TableSchemaChangeHelper {
}

bool children_column_exists(std::string table_column_name) const override {
DCHECK(children.contains(table_column_name));
return children.at(table_column_name).exists;
auto child = children.find(table_column_name);
return child != children.end() && child->second.exists;
}

void add_not_exist_children(std::string table_column_name) override {
Expand Down
11 changes: 11 additions & 0 deletions be/test/format/table/table_schema_change_helper_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,17 @@
namespace doris {
class MockTableSchemaChangeHelper : public TableSchemaChangeHelper {};

TEST(MockTableSchemaChangeHelper, UnknownStructChildDoesNotExist) {
TableSchemaChangeHelper::StructNode root;
root.add_children("file_column", "file_column",
std::make_shared<TableSchemaChangeHelper::ScalarNode>());
root.add_not_exist_children("missing_file_column");

EXPECT_TRUE(root.children_column_exists("file_column"));
EXPECT_FALSE(root.children_column_exists("missing_file_column"));
EXPECT_FALSE(root.children_column_exists("partition_column"));
}

TEST(MockTableSchemaChangeHelper, OrcNameNoSchemaChange) {
std::vector<DataTypePtr> data_types;
std::vector<std::string> column_names;
Expand Down
Loading