Skip to content

[feature](be) Support cross-AZ success quorum waiting - #66827

Open
deardeng wants to merge 1 commit into
apache:masterfrom
deardeng:impl-quorum-load-be
Open

[feature](be) Support cross-AZ success quorum waiting#66827
deardeng wants to merge 1 commit into
apache:masterfrom
deardeng:impl-quorum-load-be

Conversation

@deardeng

Copy link
Copy Markdown
Contributor

Problem Summary: Loads can reach the ordinary replica quorum before the configured minimum number of replicas in each availability zone has finished. Pass backend locations and the cross-AZ quorum policy through optional Thrift fields, wait for the per-AZ requirement in both BE tablet writers, clamp each requirement to the replicas actually present, and exclude replicas with version gaps. The authoritative commit check is provided separately by #66751. Precise tablet-level quorum-success accounting is intentionally deferred to follow-up work.

Related PR: #66751

Release note

Support waiting for configured cross-AZ successful replicas during load.

Check List (For Author)

  • Test: Unit Test and regression test added
    • BE unit test attempted with ENABLE_UNITY_BUILD=OFF ./run-be-ut.sh --run --filter=TestVTabletWriterV2.* -j16; blocked during CMake configuration because current master references missing be/src/storage/compaction/collection_statistics.cpp
    • Regression tests not run because they require the FE changes from [feature](fe) Add resource group success quorum check #66751
    • build-support/clang-format.sh and build-support/check-format.sh with clang-format 16 passed
    • build-support/run-clang-tidy.sh --build-dir be/ut_build_ASAN attempted; blocked by a toolchain stddef.h lookup failure and pre-existing diagnostics
  • Behavior changed: Yes, BE waits for the configured cross-AZ success quorum before completing load close
  • Does this need documentation: No

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

### What problem does this PR solve?

Issue Number: None

Related PR: apache#66751

Problem Summary: Loads can reach the ordinary replica quorum before the configured minimum number of replicas in each availability zone has finished. Pass backend locations and the cross-AZ quorum policy through optional Thrift fields, wait for the per-AZ requirement in both BE tablet writers, clamp each requirement to the replicas actually present, and exclude replicas with version gaps. The authoritative commit check is provided separately by apache#66751. Precise tablet-level quorum-success accounting is intentionally deferred to follow-up work.

### Release note

Support waiting for configured cross-AZ successful replicas during load.

### Check List (For Author)

- Test: Unit Test and regression test added
    - BE unit test attempted with `ENABLE_UNITY_BUILD=OFF ./run-be-ut.sh --run --filter=TestVTabletWriterV2.* -j16`; blocked during CMake configuration because current master references missing `be/src/storage/compaction/collection_statistics.cpp`
    - Regression tests not run because they require the FE changes from apache#66751
    - `build-support/clang-format.sh` and `build-support/check-format.sh` with clang-format 16 passed
    - `build-support/run-clang-tidy.sh --build-dir be/ut_build_ASAN` attempted; blocked by a toolchain `stddef.h` lookup failure and pre-existing diagnostics
- Behavior changed: Yes, BE waits for the configured cross-AZ success quorum before completing load close
- Does this need documentation: No
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng

Copy link
Copy Markdown
Contributor Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants