[fix](parquet) Handle nested nullability in predicate scans - #66799
Merged
yiguolei merged 1 commit intoAug 17, 2026
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
/review |
Contributor
There was a problem hiding this comment.
Review result: no actionable findings; comment-only approval opinion.
Critical checkpoints:
- Schema and type safety: the recursive comparator removes only Nullable wrappers at each Array, Map, or Struct node. It preserves Struct child count/order, both Map branches, and exact concrete equality for every leaf, including parameterized types.
- Predicate and materialization correctness: this changes only a DCHECK compatibility condition. Native readers still inspect the actual destination column and physical schema, scalar leaves retain exact type checks, selection/compaction cardinality remains validated, and TableReader still aligns and validates nested null maps recursively.
- Lifecycle, performance, and observability: no cursor, EOF, cleanup, ownership, cache, I/O, profile-counter, or release hot-path behavior changes. The recursive traversal runs only in debug/test assertion evaluation.
- Compatibility and interface boundaries: the implementation is the narrow backport of the helper already present on master. The detail declaration/definition links through the existing Format test target, and no TableReader/FileReader/ColumnMapper ownership boundary is changed.
- Tests: the focused positive/negative Struct helper test pins the broadened equality condition. A remaining coverage limitation is that it does not reproduce the original predicate-scheduler abort end to end or explicitly exercise Array, Map, and deeper compositions. Existing tests cover the surrounding nested-predicate, selection, and TableReader materialization paths, so I do not consider this blocking, but a focused scan-path regression would strengthen the fix.
- User focus: no additional review focus was provided; the full PR was reviewed.
- Completion: two review rounds converged with no new valuable findings, and the final changed-file/candidate sweep found no unresolved or accepted inline issues.
No local build or test was run, as required by this review runner. Normal CI remains authoritative for compilation and test execution.
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: DORIS-27887
Problem Summary:
On branch-4.1, a Parquet predicate scan can compare a reader type such as a struct with nullable descendants against a block type with nullability represented at a different nesting level. The existing debug check removes only the outer nullable wrapper and aborts the BE even though the recursive type and shape are compatible.
This change compares Array, Map, and Struct types recursively while ignoring only nullability at each nesting level. Primitive type and complex-type shape mismatches remain rejected.
This is a narrow backport of the relevant type-compatibility fix already present on master; unrelated changes are intentionally excluded.
Release note
Fix a BE crash when Parquet nested predicate columns use equivalent types with different nested nullability representations.
Check List (For Author)