-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[fix](be) Fall back from expensive Hyperscan bounded repeats #66788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HappenLee
wants to merge
6
commits into
apache:master
Choose a base branch
from
HappenLee:fix-hyperscan-bounded-repeat-fallback
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+595
−45
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
34ae8b8
[fix](be) Fall back from expensive Hyperscan bounded repeats
HappenLee f34296e
[fix](be) Add Hyperscan fallback session control
HappenLee 17e7685
[fix](be) Handle repeats after negated character classes
HappenLee eecadf3
[fix](be) Complete Hyperscan bounded-repeat safeguards
HappenLee ed8c4c1
[fix](fe) Fix load fallback code style
HappenLee 68f7208
[fix](fe) Use session snapshot for stream load planning
HappenLee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| #include "util/hyperscan_util.h" | ||
|
|
||
| #include <re2/re2.h> | ||
| #include <re2/stringpiece.h> | ||
|
|
||
| #include <charconv> | ||
| #include <string> | ||
|
|
||
| namespace doris { | ||
| namespace { | ||
|
|
||
| bool is_larger_than_fifty(std::string_view str) { | ||
| int number = 0; | ||
| auto [_, error] = std::from_chars(str.data(), str.data() + str.size(), number); | ||
| return error == std::errc() && number > 50; | ||
| } | ||
|
|
||
| std::string mask_escaped_characters_and_character_classes(std::string_view regexp) { | ||
| std::string masked_regexp(regexp); | ||
| bool escaped = false; | ||
| bool in_character_class = false; | ||
| bool character_class_can_close = false; | ||
| bool character_class_can_negate = false; | ||
| for (char& masked_character : masked_regexp) { | ||
| const char current = masked_character; | ||
| if (escaped) { | ||
| masked_character = ' '; | ||
| escaped = false; | ||
| if (in_character_class) { | ||
| character_class_can_close = true; | ||
| character_class_can_negate = false; | ||
| } | ||
| continue; | ||
| } | ||
| if (current == '\\') { | ||
| masked_character = ' '; | ||
| escaped = true; | ||
| continue; | ||
| } | ||
| if (in_character_class) { | ||
| masked_character = ' '; | ||
| if (current == ']' && character_class_can_close) { | ||
| in_character_class = false; | ||
| } else if (current == '^' && character_class_can_negate) { | ||
| character_class_can_negate = false; | ||
| } else { | ||
| character_class_can_close = true; | ||
| character_class_can_negate = false; | ||
| } | ||
| continue; | ||
| } | ||
| if (current == '[') { | ||
| masked_character = ' '; | ||
| in_character_class = true; | ||
| character_class_can_close = false; | ||
| character_class_can_negate = true; | ||
| } | ||
| } | ||
| return masked_regexp; | ||
| } | ||
|
|
||
| class SlowWithHyperscanChecker { | ||
| public: | ||
| SlowWithHyperscanChecker() | ||
| : _searcher_one_repeat(R"(\{\s*([\d]+)\s*,?\s*})"), | ||
| _searcher_two_repeats(R"(\{\s*([\d]+)\s*,\s*([\d]+)\s*\})") {} | ||
|
|
||
| bool is_slow(std::string_view regexp) const { | ||
| const std::string masked_regexp = mask_escaped_characters_and_character_classes(regexp); | ||
| return is_slow_one_repeat(masked_regexp) || is_slow_two_repeats(masked_regexp); | ||
| } | ||
|
|
||
| private: | ||
| bool is_slow_one_repeat(std::string_view regexp) const { | ||
| re2::StringPiece haystack(regexp.data(), regexp.size()); | ||
| re2::StringPiece matches[2]; | ||
| size_t start_pos = 0; | ||
| while (start_pos < haystack.size()) { | ||
| if (!_searcher_one_repeat.Match(haystack, start_pos, haystack.size(), | ||
| re2::RE2::Anchor::UNANCHORED, matches, 2)) { | ||
| break; | ||
| } | ||
|
|
||
| start_pos = matches[0].data() - haystack.data() + matches[0].size(); | ||
| if (is_larger_than_fifty({matches[1].data(), matches[1].size()})) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| bool is_slow_two_repeats(std::string_view regexp) const { | ||
| re2::StringPiece haystack(regexp.data(), regexp.size()); | ||
| re2::StringPiece matches[3]; | ||
| size_t start_pos = 0; | ||
| while (start_pos < haystack.size()) { | ||
| if (!_searcher_two_repeats.Match(haystack, start_pos, haystack.size(), | ||
| re2::RE2::Anchor::UNANCHORED, matches, 3)) { | ||
| break; | ||
| } | ||
|
|
||
| start_pos = matches[0].data() - haystack.data() + matches[0].size(); | ||
| if (is_larger_than_fifty({matches[1].data(), matches[1].size()}) || | ||
| is_larger_than_fifty({matches[2].data(), matches[2].size()})) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| re2::RE2 _searcher_one_repeat; | ||
| re2::RE2 _searcher_two_repeats; | ||
| }; | ||
|
|
||
| } // namespace | ||
|
|
||
| bool is_hyperscan_regexp_expensive(std::string_view regexp) { | ||
| static const SlowWithHyperscanChecker slow_with_hyperscan_checker; | ||
| return slow_with_hyperscan_checker.is_slow(regexp); | ||
| } | ||
|
|
||
| } // namespace doris |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.