Skip to content

[fix](orc)fix hive-orc reader read columns base in column index by default rather than column name.#65085

Open
hubgeter wants to merge 1 commit into
apache:masterfrom
hubgeter:fix_orc_default_read
Open

[fix](orc)fix hive-orc reader read columns base in column index by default rather than column name.#65085
hubgeter wants to merge 1 commit into
apache:masterfrom
hubgeter:fix_orc_default_read

Conversation

@hubgeter

@hubgeter hubgeter commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Problem Summary:
change HIVE_ORC_USE_COLUMN_NAMES session var default value to false.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hubgeter

hubgeter commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 29972 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3cfeca0d779cf0e004a2dec59b7d67d8bb2f7c2a, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17643	4072	4102	4072
q2	2011	312	199	199
q3	10358	1437	805	805
q4	4687	484	338	338
q5	7511	862	576	576
q6	177	168	135	135
q7	762	818	636	636
q8	9354	1728	1703	1703
q9	5640	4443	4447	4443
q10	6750	1805	1529	1529
q11	493	345	317	317
q12	713	554	428	428
q13	18074	3405	2808	2808
q14	276	264	229	229
q15	q16	777	780	711	711
q17	1016	974	979	974
q18	7057	5665	5460	5460
q19	1265	1294	1130	1130
q20	767	637	548	548
q21	6279	2907	2610	2610
q22	465	373	321	321
Total cold run time: 102075 ms
Total hot run time: 29972 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	5227	4818	4699	4699
q2	292	350	215	215
q3	4867	5255	4733	4733
q4	2088	2132	1393	1393
q5	4780	4803	4659	4659
q6	227	172	125	125
q7	1894	1944	1561	1561
q8	2423	2114	2144	2114
q9	7760	7367	7225	7225
q10	4775	4721	4265	4265
q11	535	379	346	346
q12	733	743	536	536
q13	3039	3384	2756	2756
q14	277	276	254	254
q15	q16	666	693	605	605
q17	1273	1244	1241	1241
q18	7310	6907	6807	6807
q19	1128	1082	1074	1074
q20	2222	2190	1935	1935
q21	5269	4606	4423	4423
q22	511	456	391	391
Total cold run time: 57296 ms
Total hot run time: 51357 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 173620 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3cfeca0d779cf0e004a2dec59b7d67d8bb2f7c2a, data reload: false

query5	4337	642	485	485
query6	456	214	192	192
query7	4913	562	353	353
query8	337	192	167	167
query9	8754	4015	4023	4015
query10	487	354	328	328
query11	5954	2311	2157	2157
query12	157	109	114	109
query13	1276	656	433	433
query14	6337	5250	4925	4925
query14_1	4280	4415	4278	4278
query15	210	198	176	176
query16	971	460	437	437
query17	922	680	556	556
query18	2405	454	336	336
query19	197	194	148	148
query20	110	107	102	102
query21	235	164	132	132
query22	13685	13500	13351	13351
query23	17308	16540	16199	16199
query23_1	16296	16279	16193	16193
query24	7528	1764	1300	1300
query24_1	1332	1288	1291	1288
query25	533	476	396	396
query26	1321	366	206	206
query27	2628	603	376	376
query28	4486	2025	2061	2025
query29	1095	644	512	512
query30	335	263	226	226
query31	1116	1104	1003	1003
query32	103	63	60	60
query33	546	328	260	260
query34	1194	1156	660	660
query35	765	777	687	687
query36	1417	1456	1255	1255
query37	161	105	93	93
query38	1894	1695	1639	1639
query39	939	932	900	900
query39_1	887	880	872	872
query40	246	174	151	151
query41	71	69	70	69
query42	98	91	95	91
query43	326	338	283	283
query44	1410	779	783	779
query45	218	199	180	180
query46	1050	1190	716	716
query47	2384	2384	2273	2273
query48	424	389	304	304
query49	590	431	313	313
query50	1121	415	328	328
query51	4443	4556	4295	4295
query52	88	88	78	78
query53	271	282	206	206
query54	286	245	233	233
query55	81	73	76	73
query56	302	295	294	294
query57	1430	1427	1327	1327
query58	302	286	265	265
query59	1592	1622	1456	1456
query60	321	284	266	266
query61	179	173	173	173
query62	697	655	598	598
query63	251	248	215	215
query64	2539	767	605	605
query65	4862	4765	4797	4765
query66	1832	514	386	386
query67	29692	29566	29450	29450
query68	3137	1625	1029	1029
query69	406	296	264	264
query70	1049	927	992	927
query71	356	334	301	301
query72	2877	2612	2330	2330
query73	862	743	442	442
query74	5109	4954	4752	4752
query75	2621	2589	2220	2220
query76	2320	1195	798	798
query77	369	398	306	306
query78	12449	12407	11878	11878
query79	1409	1176	782	782
query80	1282	531	463	463
query81	521	322	297	297
query82	654	164	125	125
query83	393	322	287	287
query84	320	163	133	133
query85	978	603	504	504
query86	436	318	280	280
query87	1841	1805	1770	1770
query88	3697	2809	2787	2787
query89	457	404	364	364
query90	1907	190	195	190
query91	201	189	164	164
query92	64	59	60	59
query93	1651	1524	971	971
query94	717	345	333	333
query95	760	585	471	471
query96	1014	786	340	340
query97	2687	2694	2568	2568
query98	211	201	200	200
query99	1164	1168	1037	1037
Total cold run time: 259358 ms
Total hot run time: 173620 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 25.29 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3cfeca0d779cf0e004a2dec59b7d67d8bb2f7c2a, data reload: false

query1	0.01	0.00	0.01
query2	0.09	0.05	0.04
query3	0.26	0.13	0.16
query4	1.61	0.14	0.14
query5	0.24	0.22	0.22
query6	1.28	1.06	1.08
query7	0.04	0.01	0.01
query8	0.06	0.04	0.04
query9	0.37	0.33	0.31
query10	0.55	0.59	0.56
query11	0.19	0.15	0.15
query12	0.18	0.15	0.15
query13	0.48	0.49	0.46
query14	1.03	1.00	1.01
query15	0.61	0.59	0.60
query16	0.34	0.34	0.33
query17	1.08	1.14	1.09
query18	0.23	0.21	0.21
query19	2.03	2.00	1.98
query20	0.02	0.01	0.01
query21	15.41	0.23	0.13
query22	4.79	0.05	0.06
query23	16.13	0.30	0.12
query24	3.06	0.47	0.33
query25	0.12	0.07	0.03
query26	0.73	0.21	0.16
query27	0.03	0.03	0.03
query28	3.45	0.92	0.57
query29	12.51	4.39	3.48
query30	0.27	0.16	0.15
query31	2.77	0.62	0.31
query32	3.23	0.60	0.50
query33	3.20	3.15	3.23
query34	15.75	4.23	3.53
query35	3.55	3.52	3.54
query36	0.55	0.46	0.40
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.18	0.16	0.15
query41	0.08	0.03	0.03
query42	0.03	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 96.75 s
Total hot run time: 25.29 s

@hello-stephen

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/29) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants