[fix](regression) Materialize JDBC array results#65084
Open
shuke987 wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Materialize JDBC array objects while regression-test reads rows from
ResultSet.Why
Arrow Flight JDBC array objects keep references to Arrow vectors owned by the live result set. The regression-test framework stores row objects first, closes the
ResultSet/Statement, and later callsOutputUtils.toCsvString(). At that point the vector insideArrowFlightJdbcArrayhas already been cleared, soArray.toString()/Array.getArray()can throwIndexOutOfBoundsException.This change converts
java.sql.Arrayvalues to plain Java list values while the result set is still alive. It also recursively handles nested Java arrays and preserves existing binary-column hex formatting.Tests
git diff --checkJdbcUtils.groovywith local Guava/slf4j classpathFull regression verification will run in CI.