[fix](test)fix CreateResourceCommandTest failure in cloud mode#65072
Draft
starocean999 wants to merge 1 commit into
Draft
[fix](test)fix CreateResourceCommandTest failure in cloud mode#65072starocean999 wants to merge 1 commit into
starocean999 wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
/review |
Contributor
There was a problem hiding this comment.
Automated review summary:
No blocking issues found. I reviewed the single changed FE test file and the surrounding CreateResourceCommand / CreateResourceInfo.validate() path. The patch is limited to JMockit fixture setup for Env and SystemInfoService in CreateResourceCommandTest, and I did not find a session/config leak, mock-scope issue, optimizer/rewrite impact, or duplicate concern from existing review context.
Critical checkpoints:
- Required AGENTS.md files: none were listed for this PR.
- Existing inline review context: no existing inline comments or replies were present.
- User focus: no additional user-provided review focus.
- Whitespace/style:
git diff --check HEAD -- fe/fe-core/src/test/java/org/apache/doris/nereids/trees/plans/commands/CreateResourceCommandTest.javapassed. - Runtime validation: targeted FE test execution could not be completed in this runner because generated-source failed before tests with missing
thirdparty/installed/bin/protoc; a separate Maven attempt timed out during dependency resolution before compilation/test execution.
Subagent conclusions:
optimizer-rewrite: no candidates; convergence round 1 returnedNO_NEW_VALUABLE_FINDINGS.tests-session-config: no candidates; convergence round 1 returnedNO_NEW_VALUABLE_FINDINGS.- Final inline comment set: empty, so this is a summary-only review.
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)