Skip to content

[fix](test)fix CreateResourceCommandTest failure in cloud mode#65072

Draft
starocean999 wants to merge 1 commit into
apache:branch-4.1from
starocean999:b41_0521
Draft

[fix](test)fix CreateResourceCommandTest failure in cloud mode#65072
starocean999 wants to merge 1 commit into
apache:branch-4.1from
starocean999:b41_0521

Conversation

@starocean999

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@starocean999

Copy link
Copy Markdown
Contributor Author

/review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review summary:

No blocking issues found. I reviewed the single changed FE test file and the surrounding CreateResourceCommand / CreateResourceInfo.validate() path. The patch is limited to JMockit fixture setup for Env and SystemInfoService in CreateResourceCommandTest, and I did not find a session/config leak, mock-scope issue, optimizer/rewrite impact, or duplicate concern from existing review context.

Critical checkpoints:

  • Required AGENTS.md files: none were listed for this PR.
  • Existing inline review context: no existing inline comments or replies were present.
  • User focus: no additional user-provided review focus.
  • Whitespace/style: git diff --check HEAD -- fe/fe-core/src/test/java/org/apache/doris/nereids/trees/plans/commands/CreateResourceCommandTest.java passed.
  • Runtime validation: targeted FE test execution could not be completed in this runner because generated-source failed before tests with missing thirdparty/installed/bin/protoc; a separate Maven attempt timed out during dependency resolution before compilation/test execution.

Subagent conclusions:

  • optimizer-rewrite: no candidates; convergence round 1 returned NO_NEW_VALUABLE_FINDINGS.
  • tests-session-config: no candidates; convergence round 1 returned NO_NEW_VALUABLE_FINDINGS.
  • Final inline comment set: empty, so this is a summary-only review.

@starocean999

Copy link
Copy Markdown
Contributor Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants