[chore](github)Remove 'Build Broker' task from .asf.yaml#65069
Conversation
Removed 'Build Broker' from the list of tasks.
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
/review |
There was a problem hiding this comment.
Review result: request changes.
I found one repository-metadata sequencing issue. The PR removes Build Broker from the required master status contexts, but the current base branch still has the Build Broker workflow job and the broker source path, and the referenced cleanup PR #64732 is still open.
Critical checkpoint conclusions:
- Goal/coverage: the intended cleanup is clear, but the current PR accomplishes it too early for
masterbranch protection. - Scope: the change is small and focused, limited to
.asf.yaml. - Concurrency/lifecycle/transaction/runtime compatibility: not applicable; this is ASF/GitHub metadata only.
- Parallel paths/config propagation: release-branch required contexts still include
Build Broker; the issue is specifically thatmasterwould stop requiring a still-live CI job. - Tests/CI: YAML parsing succeeds, and the live PR check shows
Build Brokeris skipped for this PR because no broker files changed. No Doris build/regression test was needed for this metadata-only review. - User focus: no additional user focus was provided.
Subagent conclusions: optimizer-rewrite found no optimizer/rewrite impact. tests-session-config proposed TEST-1, which I verified and accepted as MAIN-1. In convergence round 1, both live subagents returned NO_NEW_VALUABLE_FINDINGS for the same final ledger/comment set.
| - vault_p0 (Doris Cloud Regression) | ||
| - FE UT (Doris FE UT) | ||
| - BE UT (Doris BE UT) | ||
| - Build Broker |
There was a problem hiding this comment.
This drops Build Broker from the required master contexts while the job and the broker module are still live. The current base workflow still defines build-broker as name: Build Broker, runs it for fs_brokers/apache_hdfs_broker/**, and executes cd fs_brokers/apache_hdfs_broker/ && /bin/bash build.sh; the cleanup PR referenced in this PR body (#64732) is still open/unmerged. If ASF syncs this first, broker-path changes on master can merge without requiring the broker build even though that CI path still exists. Please keep this required until the broker-removal PR lands, or merge this metadata change together with/after that removal.
|
PR approved by at least one committer and no changes requested. |
fyi #64732