Skip to content

[chore](github)Remove 'Build Broker' task from .asf.yaml#65069

Merged
CalvinKirs merged 1 commit into
masterfrom
CalvinKirs-patch-8
Jul 1, 2026
Merged

[chore](github)Remove 'Build Broker' task from .asf.yaml#65069
CalvinKirs merged 1 commit into
masterfrom
CalvinKirs-patch-8

Conversation

@CalvinKirs

@CalvinKirs CalvinKirs commented Jul 1, 2026

Copy link
Copy Markdown
Member

fyi #64732

Removed 'Build Broker' from the list of tasks.
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@CalvinKirs

Copy link
Copy Markdown
Member Author

run buildall

@CalvinKirs

Copy link
Copy Markdown
Member Author

/review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review result: request changes.

I found one repository-metadata sequencing issue. The PR removes Build Broker from the required master status contexts, but the current base branch still has the Build Broker workflow job and the broker source path, and the referenced cleanup PR #64732 is still open.

Critical checkpoint conclusions:

  • Goal/coverage: the intended cleanup is clear, but the current PR accomplishes it too early for master branch protection.
  • Scope: the change is small and focused, limited to .asf.yaml.
  • Concurrency/lifecycle/transaction/runtime compatibility: not applicable; this is ASF/GitHub metadata only.
  • Parallel paths/config propagation: release-branch required contexts still include Build Broker; the issue is specifically that master would stop requiring a still-live CI job.
  • Tests/CI: YAML parsing succeeds, and the live PR check shows Build Broker is skipped for this PR because no broker files changed. No Doris build/regression test was needed for this metadata-only review.
  • User focus: no additional user focus was provided.

Subagent conclusions: optimizer-rewrite found no optimizer/rewrite impact. tests-session-config proposed TEST-1, which I verified and accepted as MAIN-1. In convergence round 1, both live subagents returned NO_NEW_VALUABLE_FINDINGS for the same final ledger/comment set.

Comment thread .asf.yaml
- vault_p0 (Doris Cloud Regression)
- FE UT (Doris FE UT)
- BE UT (Doris BE UT)
- Build Broker

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This drops Build Broker from the required master contexts while the job and the broker module are still live. The current base workflow still defines build-broker as name: Build Broker, runs it for fs_brokers/apache_hdfs_broker/**, and executes cd fs_brokers/apache_hdfs_broker/ && /bin/bash build.sh; the cleanup PR referenced in this PR body (#64732) is still open/unmerged. If ASF syncs this first, broker-path changes on master can merge without requiring the broker build even though that CI path still exists. Please keep this required until the broker-removal PR lands, or merge this metadata change together with/after that removal.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jul 1, 2026
@CalvinKirs CalvinKirs merged commit b731c4a into master Jul 1, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants