branch-4.1: [feature](workload) Support remote scan bytes breaker in workload policy #64649#65064
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.1: [feature](workload) Support remote scan bytes breaker in workload policy #64649#65064github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…icy (#64649) ### What problem does this PR solve? Issue Number: None Related PR: None Problem Summary: This PR adds a new workload policy condition `be_scan_bytes_from_remote_storage`, which allows Doris to cancel queries according to the amount of data read from remote storage by BE scan tasks. This is useful for limiting external table queries that read too much remote HDFS or object storage data. Implementation summary: - Add a new BE-side workload metric type in thrift for remote storage scan bytes. - Add FE workload policy parsing, validation, metadata mapping, and replay support for `be_scan_bytes_from_remote_storage`. - Add BE workload condition evaluation based on `io_context()->scan_bytes_from_remote_storage()`. - Add regression coverage using an existing Hive external `lineitem` table. ### Release note Support workload policy cancellation by BE remote storage scan bytes. ### Check List (For Author) - Test: - FE UT: passed - BE UT: passed - Regression test: passed, `test_workload_policy_remote_scan_bytes` - Manual test: verified existing workload policy behavior and new remote scan bytes cancellation on a deployed Doris instance - Behavior changed: Yes. Add a new workload policy condition `be_scan_bytes_from_remote_storage`. - Does this need documentation: Yes. The workload policy condition list should be updated.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #64649