branch-4.1: [fix](connection) Prevent timeout checker from stopping after an exception #65040#65063
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.1: [fix](connection) Prevent timeout checker from stopping after an exception #65040#65063github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…ption (#65040) Problem Summary: The connection timeout checker is scheduled with `scheduleAtFixedRate`. If an unchecked exception escapes from the task, `ScheduledThreadPoolExecutor` suppresses all subsequent executions. As a result, expired connections may no longer be cleaned up. This PR: - Isolates exceptions from each `ConnectContext`, so one broken connection does not prevent other connections from being checked. - Adds an outer exception boundary to keep the periodic timeout checker alive. - Logs the stack trace together with the connection ID and user for diagnosis. - Adds a unit test verifying that timeout checking continues after one context throws an exception. This applies to both MySQL and Arrow Flight SQL connection pools.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #65040