[fix](storage) check partition storage policy resource before BE update#65053
Open
gavinchou wants to merge 1 commit into
Open
[fix](storage) check partition storage policy resource before BE update#65053gavinchou wants to merge 1 commit into
gavinchou wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 29187 ms |
Contributor
TPC-DS: Total hot run time: 173768 ms |
Contributor
ClickBench: Total hot run time: 25.17 s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When
ALTER TABLE ... MODIFY PARTITION ... SET ("storage_policy" = ...)changes an existing partition policy to another policy backed by a different storage resource, Doris should reject the operation.Before this patch, the BE tablet meta update was sent before FE checked the old/new policy resource compatibility. The SQL could fail later in FE, while BE tablet meta had already persisted the new
storage_policy_id.Check List
MODIFY PARTITION (*)cross-resource failure.Tests
git diff --check