Skip to content

[fix](regression) stabilize multi leading scalar predicate#65045

Merged
hello-stephen merged 1 commit into
apache:masterfrom
shuke987:fix-multi-leading-division
Jul 1, 2026
Merged

[fix](regression) stabilize multi leading scalar predicate#65045
hello-stephen merged 1 commit into
apache:masterfrom
shuke987:fix-multi-leading-division

Conversation

@shuke987

Copy link
Copy Markdown
Collaborator

Summary

  • avoid commutative multiplication rendering drift in multi_leading scalar subquery shape output
  • rewrite the scalar predicate from 0.05 * avg(t1.c11) to avg(t1.c11) / 20.0
  • update the expected shape text for sql5_2

Testing

  • git diff --cached --check
  • not run locally: requires an available Doris regression environment

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@shuke987

Copy link
Copy Markdown
Collaborator Author

run buildall

@shuke987 shuke987 force-pushed the fix-multi-leading-division branch from 4d71de9 to 6e103d3 Compare July 1, 2026 02:20
@shuke987

shuke987 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

run buildall

@shuke987

shuke987 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

Close this earlier investigation PR; the Arrow Flight array failure has been narrowed to regression-test framework materialization after ResultSet close, so this branch is no longer the intended fix.

@shuke987 shuke987 closed this Jul 1, 2026
@shuke987 shuke987 reopened this Jul 1, 2026
@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen hello-stephen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hello-stephen hello-stephen merged commit 9502e57 into apache:master Jul 1, 2026
52 checks passed
github-actions Bot pushed a commit that referenced this pull request Jul 1, 2026
## Summary

- avoid commutative multiplication rendering drift in `multi_leading`
scalar subquery shape output
- rewrite the scalar predicate from `0.05 * avg(t1.c11)` to `avg(t1.c11)
/ 20.0`
- update the expected shape text for `sql5_2`

## Testing

- [x] `git diff --cached --check`
- [ ] not run locally: requires an available Doris regression
environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.1.x reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants