Skip to content

branch-4.1:[fix](maxcompute)Fix MaxCompute IN predicate pushdown polarity (#65083)#64358

Open
hubgeter wants to merge 2 commits into
apache:branch-4.1from
hubgeter:fix_mc_in_predicate
Open

branch-4.1:[fix](maxcompute)Fix MaxCompute IN predicate pushdown polarity (#65083)#64358
hubgeter wants to merge 2 commits into
apache:branch-4.1from
hubgeter:fix_mc_in_predicate

Conversation

@hubgeter

@hubgeter hubgeter commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

bp #65083
Problem Summary:
fix maxcompute error in predicate pushdown.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hubgeter hubgeter force-pushed the fix_mc_in_predicate branch from 6792355 to c85a5f9 Compare June 25, 2026 07:23
@hubgeter

Copy link
Copy Markdown
Contributor Author

run buildall

@hubgeter hubgeter marked this pull request as ready for review June 25, 2026 07:25
@hubgeter hubgeter requested a review from yiguolei as a code owner June 25, 2026 07:25
@hubgeter

Copy link
Copy Markdown
Contributor Author

/review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review found one required cleanup.

Critical checkpoints:

  • MaxCompute IN/NOT IN polarity: the production mapping now matches Doris InPredicate.isNotIn(), and I did not find a semantic regression in the MaxCompute scan/filter path.
  • Regression coverage and session/config: the added remote MaxCompute cases exercise single and multi IN/NOT IN plus non-pushdown comparisons; no separate session/config propagation issue was found.
  • CI/style: git diff --check f5561492338cc1d27eedb6ac4e0e75593befc218 c85a5f903fb9a8c448b8120567146f6ce770089b fails because the new expected-output file has a blank line at EOF; see the inline comment.
  • User focus: no additional user-provided review focus was present.

Subagent conclusions:

  • optimizer-rewrite: no candidates became inline comments; convergence round CR-1 returned NO_NEW_VALUABLE_FINDINGS.
  • tests-session-config: TSC-001 was accepted as M-001 and submitted as the inline comment; convergence round CR-1 returned NO_NEW_VALUABLE_FINDINGS.

-- !not_in_non_pushdown --
2 string_value
4 string_value

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new expected-output file leaves an extra blank line after the final row, and the patch currently fails git diff --check with new blank line at EOF on this file. Please remove the trailing blank line so the PR passes the repository's whitespace check.

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉
Increment coverage report
Complete coverage report

@hubgeter

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/15) 🎉
Increment coverage report
Complete coverage report

@hubgeter hubgeter changed the title [fix](maxcompute)Fix MaxCompute IN predicate pushdown polarity branch-4.1:[fix](maxcompute)Fix MaxCompute IN predicate pushdown polarity Jul 1, 2026
@hubgeter hubgeter force-pushed the fix_mc_in_predicate branch from 9e64059 to 1b6d475 Compare July 1, 2026 06:51
@hubgeter

hubgeter commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hubgeter hubgeter changed the title branch-4.1:[fix](maxcompute)Fix MaxCompute IN predicate pushdown polarity branch-4.1:[fix](maxcompute)Fix MaxCompute IN predicate pushdown polarity (#65083) Jul 1, 2026
@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/64) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants