-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[fix](inverted index) resolve variant sub-column indexes for score() #62992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
airborne12
wants to merge
18
commits into
apache:master
Choose a base branch
from
airborne12:air-36-variant-empty-score-master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
69bc2d8
[fix](inverted index) resolve variant sub-column indexes for score query
airborne12 1cc5c93
[fix](inverted index) address variant score review comments
airborne12 d483432
[fix](inverted index) handle variant score parent index fallback
airborne12 21c9e64
[fix](inverted index) minimize variant util changes
airborne12 69b5dc4
[fix](inverted index) collapse variant score fallback and drop typed_…
airborne12 948049c
[refactor](inverted index) extract resolve_subcolumn_indexes_inherita…
airborne12 01eb802
[test](inverted index) regression for variant score with field_patter…
airborne12 e12ab7f
[fix](inverted index) resolve score stats for materialized variant paths
airborne12 452a20e
[fix](inverted index) format variant column reader
airborne12 a1730c2
[fix](inverted index) restore find_subcolumn_tablet_indexes to master
airborne12 efdde31
[fix](inverted index) restrict collector fallback to schema-only fiel…
airborne12 3d90512
[refactor](inverted index) drop unused resolve_subcolumn_indexes_inhe…
airborne12 6c4fff4
[test](inverted index) cover all branches of MatchPredicateCollector:…
airborne12 00738dd
[fix](inverted index) clone parent plain index for VARIANT placeholde…
airborne12 2c16093
[chore](format) clang-format pass on PR #62992 changes
airborne12 910092c
[test](inverted index) add direct UTs for PredicateCollector helpers
airborne12 ca04990
[test](inverted index) call MatchPredicateCollector::collect() direct…
airborne12 3060511
[chore](format) clang-format pass on collector branch tests
airborne12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (column.is_extracted_column()) continue;