Skip to content

[Feature] Add ST_CoordDim and ST_Dimension geo functions#61442

Open
batuhanYagmurr wants to merge 2 commits intoapache:masterfrom
batuhanYagmurr:feature/geo-coorddim-dimension
Open

[Feature] Add ST_CoordDim and ST_Dimension geo functions#61442
batuhanYagmurr wants to merge 2 commits intoapache:masterfrom
batuhanYagmurr:feature/geo-coorddim-dimension

Conversation

@batuhanYagmurr
Copy link

Add two new geo scalar functions:

  • ST_CoordDim: Returns coordinate dimension of geometry (always 2 for 2D)
  • ST_Dimension: Returns topological dimension (Point=0, Line=1, Polygon=2)

FE: Added expression classes, registered in BuiltinScalarFunctions, added visitor methods in ScalarFunctionVisitor.
BE: Added struct implementations and registered in functions_geo.cpp.

What problem does this PR solve?

Issue Number: close #48203

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Add two new geo scalar functions:
- ST_CoordDim: Returns coordinate dimension of geometry (always 2 for 2D)
- ST_Dimension: Returns topological dimension (Point=0, Line=1, Polygon=2)

FE: Added expression classes, registered in BuiltinScalarFunctions,
added visitor methods in ScalarFunctionVisitor.
BE: Added struct implementations and registered in functions_geo.cpp.
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue] Support All SQL Functions in Other SQL System

2 participants