Skip to content

[opt](build)make checkstyle.xml compatible to vscode #61431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
englefly merged 4 commits into from
Mar 20, 2026
+11 −3
Merged

[opt](build)make checkstyle.xml compatible to vscode #61431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64b03b1
make checkstyle.xml compatible to vscode
englefly Mar 17, 2026
c0dbd40
set config_loc for mvn < 3.0
englefly Mar 18, 2026
abbf6bc
fix
englefly Mar 18, 2026
155fea4
2
englefly Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions fe/check/checkstyle/checkstyle.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ under the License.
</module>

<module name="SuppressionFilter">
<property name="file" value="check/checkstyle/suppressions.xml"/>
<property name="file" value="${config_loc}/suppressions.xml"/>
<property name="optional" value="true"/>
</module>
<module name="SuppressWithPlainTextCommentFilter">
Expand All @@ -45,7 +45,7 @@ under the License.
<property name="eachLine" value="true"/>
</module>
<module name="Header">
<property name="headerFile" value="check/checkstyle/checkstyle-apache-header.txt"/>
<property name="headerFile" value="${config_loc}/checkstyle-apache-header.txt"/>
<property name="fileExtensions" value="java"/>
</module>
<module name="LineLength">
Expand Down Expand Up @@ -161,7 +161,7 @@ under the License.
<property name="tokens" value="IMPORT, STATIC_IMPORT, PACKAGE_DEF"/>
</module>
<module name="ImportControl">
<property name="file" value="check/checkstyle/import-control.xml"/>
<property name="file" value="${config_loc}/import-control.xml"/>
</module>
<module name="RedundantImport"/>
<module name="UnusedImports"/>
Expand Down
8 changes: 8 additions & 0 deletions fe/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,14 @@ under the License.
<failsOnError>true</failsOnError>
<linkXRef>false</linkXRef>
<includeTestSourceDirectory>true</includeTestSourceDirectory>
<!-- Explicitly set config_loc so that checkstyle.xml can reference sibling
files via ${config_loc}/suppressions.xml etc.
maven-checkstyle-plugin 3.0+ sets this automatically, but older
versions do not, causing "Property ${config_loc} has not been set".
${maven.multiModuleProjectDirectory} always points to the directory
from which Maven was invoked (the fe/ root), so this works for all
submodules regardless of nesting depth. Requires Maven 3.3.1+. -->
<propertyExpansion>config_loc=${maven.multiModuleProjectDirectory}/check/checkstyle</propertyExpansion>
<excludes>
**/apache/doris/thrift/**/*,
**/apache/parquet/**/*
Expand Down
Loading