Skip to content

Conversation

@linrrzqqq
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@linrrzqqq linrrzqqq marked this pull request as draft January 30, 2026 16:34
@Thearas
Copy link
Contributor

Thearas commented Jan 30, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@linrrzqqq
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32156 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d8caee5d72be046336ed134581d5aa4615e7d6d4, data reload: false

------ Round 1 ----------------------------------
q1	17650	5217	5104	5104
q2	2123	312	194	194
q3	10168	1318	748	748
q4	10209	811	312	312
q5	7528	2217	1878	1878
q6	211	183	149	149
q7	856	738	602	602
q8	9265	1440	1125	1125
q9	5546	4881	4819	4819
q10	6877	1942	1578	1578
q11	540	311	281	281
q12	403	374	226	226
q13	17771	4075	3238	3238
q14	234	244	222	222
q15	892	820	815	815
q16	697	702	611	611
q17	653	771	520	520
q18	6947	6500	7427	6500
q19	2289	1028	685	685
q20	423	378	241	241
q21	2908	2334	2028	2028
q22	391	364	280	280
Total cold run time: 104581 ms
Total hot run time: 32156 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5612	5461	5631	5461
q2	285	355	270	270
q3	2411	2912	2518	2518
q4	1449	1856	1895	1856
q5	4651	4540	4479	4479
q6	226	179	176	176
q7	2027	1947	1840	1840
q8	2546	2379	2335	2335
q9	7442	7545	7358	7358
q10	2884	3099	2553	2553
q11	540	458	433	433
q12	610	681	541	541
q13	3588	4061	3240	3240
q14	277	291	261	261
q15	832	791	802	791
q16	632	677	634	634
q17	1079	1316	1379	1316
q18	7548	7285	7149	7149
q19	792	798	783	783
q20	1967	2035	1922	1922
q21	4566	4318	4091	4091
q22	582	544	552	544
Total cold run time: 52546 ms
Total hot run time: 50551 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.65 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d8caee5d72be046336ed134581d5aa4615e7d6d4, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.04	0.04
query3	0.26	0.09	0.08
query4	1.61	0.11	0.12
query5	0.27	0.25	0.25
query6	1.16	0.67	0.67
query7	0.03	0.02	0.03
query8	0.06	0.04	0.05
query9	0.58	0.51	0.50
query10	0.56	0.56	0.54
query11	0.14	0.09	0.10
query12	0.14	0.10	0.10
query13	0.63	0.61	0.61
query14	1.07	1.07	1.06
query15	0.88	0.87	0.88
query16	0.38	0.39	0.40
query17	1.11	1.18	1.12
query18	0.22	0.21	0.20
query19	2.04	2.05	2.10
query20	0.02	0.01	0.02
query21	15.41	0.27	0.15
query22	5.34	0.05	0.05
query23	16.16	0.28	0.10
query24	1.83	0.45	0.86
query25	0.12	0.12	0.08
query26	0.14	0.13	0.13
query27	0.06	0.06	0.04
query28	5.40	1.13	0.97
query29	12.55	3.88	3.15
query30	0.27	0.14	0.13
query31	2.82	0.62	0.43
query32	3.24	0.61	0.51
query33	3.20	3.29	3.24
query34	16.22	5.45	4.76
query35	4.76	4.80	4.80
query36	0.65	0.50	0.48
query37	0.12	0.07	0.07
query38	0.07	0.05	0.04
query39	0.04	0.03	0.03
query40	0.18	0.16	0.15
query41	0.09	0.03	0.02
query42	0.05	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 100.08 s
Total hot run time: 28.65 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.48% (19274/36723)
Line Coverage 35.96% (179046/497963)
Region Coverage 32.35% (138806/429038)
Branch Coverage 33.31% (60076/180351)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 69.96% (25183/35998)
Line Coverage 52.53% (260971/496786)
Region Coverage 49.98% (216621/433448)
Branch Coverage 51.30% (92896/181083)

@linrrzqqq linrrzqqq changed the title [test] [Fix](Agg) Fix the problem that add_batch cannot handle rows with null value correctly Jan 31, 2026
@linrrzqqq
Copy link
Contributor Author

run buildall

@linrrzqqq linrrzqqq marked this pull request as ready for review January 31, 2026 05:54
@doris-robot
Copy link

TPC-H: Total hot run time: 32655 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9fe6b4660e56dd7857b426e04e75bd89be573541, data reload: false

------ Round 1 ----------------------------------
q1	17728	5341	5114	5114
q2	2184	300	191	191
q3	10244	1288	742	742
q4	10239	867	315	315
q5	7456	2157	1909	1909
q6	191	179	149	149
q7	885	732	611	611
q8	9257	1395	1179	1179
q9	5156	4802	4898	4802
q10	7088	1962	1586	1586
q11	540	296	286	286
q12	364	377	224	224
q13	17779	4060	3218	3218
q14	235	236	214	214
q15	889	823	817	817
q16	666	671	629	629
q17	651	773	553	553
q18	7081	6760	7108	6760
q19	1815	1071	654	654
q20	407	399	251	251
q21	3122	2404	2175	2175
q22	375	324	276	276
Total cold run time: 104352 ms
Total hot run time: 32655 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5544	5458	5523	5458
q2	268	367	246	246
q3	2502	2984	2639	2639
q4	1694	1956	1478	1478
q5	4765	4610	4657	4610
q6	213	186	134	134
q7	2006	1941	1817	1817
q8	2618	2399	2472	2399
q9	7497	7566	7406	7406
q10	2733	2812	2433	2433
q11	513	459	442	442
q12	621	673	571	571
q13	3567	3998	3215	3215
q14	277	302	268	268
q15	839	793	790	790
q16	638	687	628	628
q17	1070	1243	1308	1243
q18	7484	7379	7301	7301
q19	838	835	845	835
q20	1989	2069	1889	1889
q21	4501	4279	4113	4113
q22	583	541	516	516
Total cold run time: 52760 ms
Total hot run time: 50431 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.74 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9fe6b4660e56dd7857b426e04e75bd89be573541, data reload: false

query1	0.05	0.04	0.05
query2	0.09	0.05	0.05
query3	0.25	0.08	0.08
query4	1.62	0.11	0.10
query5	0.27	0.25	0.25
query6	1.17	0.69	0.68
query7	0.04	0.03	0.03
query8	0.05	0.04	0.04
query9	0.57	0.49	0.51
query10	0.55	0.54	0.54
query11	0.14	0.10	0.09
query12	0.14	0.11	0.11
query13	0.64	0.61	0.61
query14	1.06	1.06	1.06
query15	0.89	0.86	0.85
query16	0.40	0.39	0.40
query17	1.14	1.13	1.14
query18	0.23	0.22	0.21
query19	2.02	1.99	1.98
query20	0.02	0.01	0.02
query21	15.39	0.28	0.14
query22	5.07	0.05	0.05
query23	15.74	0.30	0.11
query24	1.47	0.65	0.74
query25	0.09	0.08	0.07
query26	0.14	0.13	0.12
query27	0.08	0.06	0.06
query28	4.43	1.14	0.96
query29	12.57	3.88	3.16
query30	0.27	0.13	0.12
query31	2.82	0.65	0.41
query32	3.25	0.59	0.51
query33	3.22	3.28	3.27
query34	16.20	5.44	4.72
query35	4.80	4.84	4.77
query36	0.66	0.50	0.50
query37	0.11	0.07	0.07
query38	0.07	0.04	0.04
query39	0.04	0.02	0.03
query40	0.18	0.16	0.15
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 98.1 s
Total hot run time: 28.74 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.48% (19274/36723)
Line Coverage 35.96% (179060/497963)
Region Coverage 32.40% (139023/429038)
Branch Coverage 33.32% (60095/180351)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.59% (25772/35998)
Line Coverage 54.26% (269538/496786)
Region Coverage 51.89% (224904/433448)
Branch Coverage 53.27% (96460/181083)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants