Skip to content

[fix](ddl) Reject $ in table names at create time #60370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suxiaogang223 wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −4
Open

[fix](ddl) Reject $ in table names at create time #60370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4ab395
Reject $ in table names
suxiaogang223 Jan 29, 2026
1f6b09d
Add regression case for $ in table name
suxiaogang223 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fe/fe-core/src/main/java/org/apache/doris/common/FeNameFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public class FeNameFormat {
// please modify error msg when FeNameFormat.checkCommonName throw exception in CreateRoutineLoadStmt
private static final String COMMON_NAME_REGEX = "^[a-zA-Z][a-zA-Z0-9\\-_]{0,63}$";
private static final String UNDERSCORE_COMMON_NAME_REGEX = "^[_a-zA-Z][a-zA-Z0-9\\-_]{0,63}$";
private static final String TABLE_NAME_REGEX = "^[a-zA-Z0-9\\-_$]*$";
private static final String TABLE_NAME_REGEX = "^[a-zA-Z0-9\\-_]*$";
private static final String USER_NAME_REGEX = "^[a-zA-Z][a-zA-Z0-9.\\-_]*$";
private static final String REPOSITORY_NAME_REGEX = "^[a-zA-Z][a-zA-Z0-9\\-_]{0,255}$";
private static final String COLUMN_NAME_REGEX
Expand All @@ -44,7 +44,7 @@ public class FeNameFormat {
private static final String UNICODE_LABEL_REGEX = "^[\\-_A-Za-z0-9:\\p{L}]{1," + Config.label_regex_length + "}$";
private static final String UNICODE_COMMON_NAME_REGEX = "^[a-zA-Z\\p{L}][a-zA-Z0-9\\-_\\p{L}]{0,63}$";
private static final String UNICODE_UNDERSCORE_COMMON_NAME_REGEX = "^[_a-zA-Z\\p{L}][a-zA-Z0-9\\-_\\p{L}]{0,63}$";
private static final String UNICODE_TABLE_NAME_REGEX = "^[\\s\\S]*[\\S]$";
private static final String UNICODE_TABLE_NAME_REGEX = "^(?!.*\\$)[\\s\\S]*[\\S]$";
private static final String UNICODE_USER_NAME_REGEX = "^[a-zA-Z\\p{L}][a-zA-Z0-9.\\-_\\p{L}]*$";
private static final String UNICODE_COLUMN_NAME_REGEX
= "^[\\s\\S]{0,255}[\\S]$";
Expand Down
4 changes: 2 additions & 2 deletions fe/fe-core/src/test/java/org/apache/doris/common/FeNameFormatTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ void testTableName() {
"a_1", // Underscore + number
"B2", // Uppercase letter + number
"1abc", // Starts with digit
"abc$", // Contains invalid symbol $
"-abc", // Starts with hyphen
"_abc" // Starts with underscore
);
Expand All @@ -98,7 +97,8 @@ void testTableName() {
"", // Empty string
"x ", // space character as last one
"x\t", // table character as last one
"x\n" // enter character as last one
"x\n", // enter character as last one
"abc$" // Contains invalid symbol $
);

List<String> unicodeValid = Lists.newArrayList(
Expand Down
13 changes: 13 additions & 0 deletions regression-test/suites/ddl_p0/test_create_table.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,19 @@ suite("sql_create_time_range_table") {
exception "Disable to create table"
}

test {
sql """
CREATE TABLE tbl\$refs (
k1 int,
k2 int
)
DUPLICATE KEY (`k1`)
DISTRIBUTED BY HASH(`k2`) BUCKETS 1
PROPERTIES ("replication_num" = "1");
"""
exception "Incorrect table name"
}

// DDL/DML return 1 row and 1 column, the only value is update row count
assertTrue(result1.size() == 1)
assertTrue(result1[0].size() == 1)
Expand Down