Skip to content

Conversation

@niumy0701
Copy link

close #17813

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@github-actions github-actions bot added UI ui and front end related backend test labels Jan 7, 2026
@niumy0701 niumy0701 changed the title Improvement 17813 update datasource password [Improvement-17813][API/UI] update datasource password Jan 7, 2026
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this kind of change. This is inconsistent with what we discussed in #17813 .

BTW, You should stop using AI code directly, which will not only waste reviewer's time, but also reduce people's trust in you.

@niumy0701
Copy link
Author

We don't need this kind of change. This is inconsistent with what we discussed in #17813 .

BTW, You should stop using AI code directly, which will not only waste reviewer's time, but also reduce people's trust in you.

The front-end code is indeed generated by AI, and I have tested its functionality and found no issues. Can we embrace the trend of AI popularity

@SbloodyS
Copy link
Member

SbloodyS commented Jan 8, 2026

The front-end code is indeed generated by AI, and I have tested its functionality and found no issues. Can we embrace the trend of AI popularity

Your code is full of AI traces.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
57.3% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend discussion discussion test UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DSIP-101][ApiServer] How should the password be handled more elegantly when editing a data source?

3 participants