[Fix-17834] [Master] Fix workflow failure strategy cannot work #17851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...g/apache/dolphinscheduler/server/master/engine/workflow/policy/IWorkflowFailureStrategy.java
Fixed
Show fixed
Hide fixed
ruanwenjun
force-pushed
the
dev_wenjun_fix17834
branch
from
f111c62 to
c481652
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fix17834
branch
from
c481652 to
a645d18
Compare
| public interface IWorkflowFailureStrategy { | ||
|
|
||
| void onTaskFailure(IWorkflowExecutionRunnable workflowExecutionRunnable, | ||
| ITaskExecutionRunnable taskExecutionRunnable); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| ITaskExecutionRunnable taskExecutionRunnable); | ||
|
|
||
| boolean canTriggerSuccessor(IWorkflowExecutionRunnable workflowExecutionRunnable, | ||
| ITaskExecutionRunnable taskExecutionRunnable); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| @Getter | ||
| private final List<IWorkflowLifecycleListener> workflowInstanceLifecycleListeners; | ||
|
|
||
| @Getter |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
ruanwenjun
force-pushed
the
dev_wenjun_fix17834
branch
3 times, most recently
from
a561ee4 to
5afe620
Compare
zhongjiajie
approved these changes
Jan 10, 2026
ruanwenjun
force-pushed
the
dev_wenjun_fix17834
branch
from
5afe620 to
7f967df
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #17834
Brief change log
Verify this pull request
Test by IT case.
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md