You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@SbloodySWorkflowInstanceFailoverTestCase.testGlobalFailover_runningWorkflow_fromAnotherMaster failed.
This unit test failure appears to be unrelated to my changes. Please help me out.
@SbloodySWorkflowInstanceFailoverTestCase.testGlobalFailover_runningWorkflow_fromAnotherMaster failed. This unit test failure appears to be unrelated to my changes. Please help me out.
@SbloodySWorkflowInstanceFailoverTestCase.testGlobalFailover_runningWorkflow_fromAnotherMaster failed. This unit test failure appears to be unrelated to my changes. Please help me out.
I've already rerun all tests.
@SbloodyS Unit tests failed again, any idea what might be causing this?
@ruanwenjun ok thanks. @SbloodyS I've merged #17807 Please rerun the checks. I'm wandering if I can rerun checks by myself?
Right now, the CI need committer approve, this is primarily to reduce unnecessary CI resource consumption. If we can move the CI action to developer's repo, then we can remove this.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qiong-zhou
requested review from
Gallardot,
SbloodyS and
caishunfeng
as code owners
ruanwenjun
force-pushed
the
Improvement-17788
branch
from
Purpose of the pull request
Optimization of log processing for RemoteShellTask. Reading the logs by line to avoid large string. close #17788
Brief change log
Modified
RemoteExecutor.javaVerify this pull request
This change added tests and can be verified as follows:
testTrack()inRemoteExecutorTestto verify the change.