fix(config-ui): group connections by name, not by list position - #9130
Open
stigi wants to merge 1 commit into
Open
fix(config-ui): group connections by name, not by list position#9130stigi wants to merge 1 commit into
stigi wants to merge 1 commit into
Conversation
The A-N and O-Z headings were produced by cutting the plugin list at the first plugin id starting with a letter from o to z. That agrees with the headings only while each config's `sort` value runs alphabetically, and it stopped doing so as plugins were appended in the order they were added: Asana, Kiro, Linear and incident.io are all listed after Opsgenie, so all four appeared under O-Z. Group by the first letter of the displayed name instead, which is what a reader is matching against, and extract the decision into a pure function with tests. Generated-by: Claude Code (Claude Opus 5) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The A-N and O-Z headings on the Connections page put several plugins under
the wrong letter.
Asana,Kiro,Linearandincident.ioall appear underO-Z today.
The grouping cut the list at the first plugin id starting with a letter from
otoz, and treated everything after that point as O-Z:That is only equivalent to grouping by letter while each plugin config's
sortvalue happens to run alphabetically. It no longer does: plugins have been
appended in the order they were added, so
opsgenie(sort 10) sits ahead ofasana(12),kiro(12),linear(13) andincidentio(19), and the cutlands in the middle of the alphabet.
This groups by the first letter of the displayed name instead — what a
reader is actually matching the heading against — and extracts the decision
into a pure
splitPluginsByInitialwith unit tests.Does this close any open issues?
No issue filed; the misplaced tiles are visible on the Connections page of any
current build.
Screenshots
Not included: the change moves four existing tiles between two headings, which
reads more clearly as the plugin ids above than as a screenshot.
Tests
config-ui/src/__tests__/connections-grouping.test.ts— four cases: grouping byname rather than position, no plugin lost from either group, case-insensitive
comparison (so
incident.iogroups under I), and a fallback to the plugin idwhen a config has no name. Verified against the previous implementation: two of
the four fail on it.