Repository navigation
Conversation
tisonkun
marked this pull request as ready for review
November 8, 2026 05:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reserve byte 3 for XOR flags and use a 24-byte header matching the proposal in datasketches-java #795. Writers emit zero flags; readers reject unsupported flags. The fingerprint payload and query algorithm are unchanged.
Refresh the Java-generated scalar and UTF-8/raw-byte fixtures, preserve byte-for-byte round trips, and cover unsupported flags and the relocated length field.
cargo x check,cargo x test, andcargo x lintpass.The format version remains 1 pending release coordination on the Java PR. Java 9.1.0-RC1 contains an earlier count-bearing format; this change must not be merged as a finalized cross-language format until the version and legacy-reader policy are agreed.