Repository navigation
Conversation
The test jobs run `mvn surefire:test` on the artifact from the build job, which held only the jars, the poms and the test resources. Surefire reads target/classes and target/test-classes, so it found nothing to run and reported "Tests run: 0, BUILD SUCCESS". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Closing: this isn't needed. The matrix is meant to test the jars, not the class directories. The fix belongs in the reusable workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JDK & OS matrix jobs have been passing without running any tests. Their logs show
Tests run: 0andBUILD SUCCESS, on runs back to at least September.The test jobs run
mvn surefire:teston the artifact from the build job. That artifact held only the jars, the poms and the test resources, but surefire readstarget/classesandtarget/test-classes. This adds both directories to the artifact.I reproduced this locally by copying only the artifact's contents to a clean directory. As it was, surefire reported "No tests to run". With the two directories added, all 2336 tests ran and passed on macOS.
This PR's own matrix run is the real test. These may be the first tests to run on Windows and Linux in CI for some time, so it could turn up platform failures.
🤖 Generated with Claude Code