Repository navigation
Conversation
Member
|
Thanks, Hyeonho. The change looks right to me: it adds the same One small request: please restore the commented-out "for manual comparison with Java" test, or move its removal to a separate change, since it isn't related to this fix. We're finishing a bug-fix release and holding other PRs until it's out, so this will wait until then. It only affects a few small values of |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensure_enough_sections() doubled the number of sections even when the
section size was already MIN_K and the reduced size rounded back to
MIN_K. The nominal capacity then grew 2x instead of the sqrt(2).
This is same as java.