Skip to content

chore: check license headers in SQL logic tests - #25182

Merged
alamb merged 1 commit into
apache:mainfrom
Xuanwo:xuanwo/slt-license-headers
Sep 11, 2026
Merged

chore: check license headers in SQL logic tests#25182
alamb merged 1 commit into
apache:mainfrom
Xuanwo:xuanwo/slt-license-headers

Conversation

@Xuanwo

@Xuanwo Xuanwo commented Sep 11, 2026

Copy link
Copy Markdown
Member

Which issue does this PR close?

No linked issue; follows up on missing license headers found during release review.

Rationale for this change

Several SQL logic test files lack ASF license headers, and the existing license check only selects Rust, Python, and TypeScript files. Include SQL logic tests in that check to catch missing headers in future changes.

What changes are included in this PR?

  • Add ASF headers to 18 SQL logic test files, including sort_pushdown.slt, datetime/arith_timestamp_duration.slt, datetime/arith_time_interval.slt, and parquet_cdc_config.slt.
  • Select all *.slt files and map the extension to HawkEye's script comment style.
  • Normalize 406 existing headers and their spacing to the canonical format required by HawkEye 7.0.0. SQL statements and expected results are unchanged.

What is the testing strategy for this PR?

  • The existing license check covers all 517 SQL logic test files and passes with no unsupported files.
  • Temporarily removing a header from both a top-level and a nested SQL logic test makes the CI license check fail; restoring the headers makes it pass.
  • Compare all modified SQL logic test bodies against the base commit, excluding leading blank lines: unchanged.
  • Full extended workspace test command passes (11,605 Rust tests passed, 8 ignored, plus the SQL logic test runner).
  • cargo fmt --all, cargo clippy --all-targets --all-features -- -D warnings, and ./dev/rust_lint.sh.

Are there any user-facing changes?

No. This changes license headers and CI coverage only.

@github-actions github-actions Bot added the sqllogictest SQL Logic Tests (.slt) label Sep 11, 2026
@Xuanwo
Xuanwo marked this pull request as ready for review September 11, 2026 04:36
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.91%. Comparing base (7e5f40a) to head (231d066).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25182      +/-   ##
==========================================
- Coverage   81.91%   81.91%   -0.01%     
==========================================
  Files        1132     1132              
  Lines      421117   421117              
  Branches   421117   421117              
==========================================
- Hits       344961   344957       -4     
- Misses      55767    55770       +3     
- Partials    20389    20390       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kumarUjjawal kumarUjjawal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Xuanwo

This is nice.

@alamb
alamb added this pull request to the merge queue Sep 11, 2026
@alamb

alamb commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Thank you @Xuanwo and @kumarUjjawal

Merged via the queue into apache:main with commit 1fb8980 Sep 11, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants