chore: check license headers in SQL logic tests - #25182
Merged
Merged
Conversation
Xuanwo
marked this pull request as ready for review
September 11, 2026 04:36
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25182 +/- ##
==========================================
- Coverage 81.91% 81.91% -0.01%
==========================================
Files 1132 1132
Lines 421117 421117
Branches 421117 421117
==========================================
- Hits 344961 344957 -4
- Misses 55767 55770 +3
- Partials 20389 20390 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kumarUjjawal
approved these changes
Sep 11, 2026
kumarUjjawal
left a comment
Contributor
There was a problem hiding this comment.
Thank you @Xuanwo
This is nice.
Contributor
|
Thank you @Xuanwo and @kumarUjjawal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No linked issue; follows up on missing license headers found during release review.
Rationale for this change
Several SQL logic test files lack ASF license headers, and the existing license check only selects Rust, Python, and TypeScript files. Include SQL logic tests in that check to catch missing headers in future changes.
What changes are included in this PR?
sort_pushdown.slt,datetime/arith_timestamp_duration.slt,datetime/arith_time_interval.slt, andparquet_cdc_config.slt.*.sltfiles and map the extension to HawkEye'sscriptcomment style.What is the testing strategy for this PR?
cargo fmt --all,cargo clippy --all-targets --all-features -- -D warnings, and./dev/rust_lint.sh.Are there any user-facing changes?
No. This changes license headers and CI coverage only.