Skip to content

fix: report a negative array_resize size as a user error #25179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1fanwang wants to merge 3 commits into
base: main
Choose a base branch
from
+24 −8
Open

fix: report a negative array_resize size as a user error #25179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f25bf2e
fix: report a negative array_resize size as a user error
1fanwang Sep 10, 2026
847b155
Remove the resize error history comment
1fanwang Sep 11, 2026
890200e
Merge branch 'main' into 1fannnw/array-resize-negative-size
neilconway Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions datafusion/functions-nested/src/resize.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,16 @@ use arrow::array::{
};
use arrow::buffer::OffsetBuffer;
use arrow::datatypes::DataType;
use arrow::datatypes::{ArrowNativeType, Field};
use arrow::datatypes::Field;
use arrow::datatypes::{
DataType::{LargeList, List},
FieldRef,
};
use datafusion_common::cast::{as_int64_array, as_large_list_array, as_list_array};
use datafusion_common::utils::ListCoercion;
use datafusion_common::{Result, ScalarValue, exec_err, internal_datafusion_err};
use datafusion_common::{
Result, ScalarValue, exec_datafusion_err, exec_err, internal_datafusion_err,
};
use datafusion_expr::{
ArrayFunctionArgument, ArrayFunctionSignature, ColumnarValue, Documentation,
ScalarFunctionArgs, ScalarUDFImpl, Signature, TypeSignature, Volatility,
Expand Down Expand Up @@ -186,6 +188,13 @@ fn array_resize_inner(arg: &[ArrayRef]) -> Result<ArrayRef> {
}
}

fn resize_count(count_array: &Int64Array, idx: usize) -> Result<usize> {
let c = count_array.value(idx);
usize::try_from(c).map_err(|_| {
exec_datafusion_err!("array_resize: size must not be negative, got {c}")
})
}

/// array_resize keep the original array and append the default element to the end
fn general_list_resize<O: OffsetSizeTrait + TryInto<i64>>(
array: &GenericListArray<O>,
Expand All @@ -206,9 +215,7 @@ fn general_list_resize<O: OffsetSizeTrait + TryInto<i64>>(
if array.is_null(row_index) || count_array.is_null(row_index) {
continue;
}
let target_count = count_array.value(row_index).to_usize().ok_or_else(|| {
internal_datafusion_err!("array_resize: failed to convert size to usize")
})?;
let target_count = resize_count(count_array, row_index)?;
output_values_len =
output_values_len.checked_add(target_count).ok_or_else(|| {
internal_datafusion_err!("array_resize: output size overflow")
Expand Down Expand Up @@ -324,9 +331,7 @@ where
}
null_builder.append_non_null();

let count = count_array.value(row_index).to_usize().ok_or_else(|| {
internal_datafusion_err!("array_resize: failed to convert size to usize")
})?;
let count = resize_count(count_array, row_index)?;
let count = O::usize_as(count);
let start = offset_window[0];
if start + count > offset_window[1] {
Expand Down
11 changes: 11 additions & 0 deletions datafusion/sqllogictest/test_files/array/array_resize.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,4 +193,15 @@ NULL
[61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 9, 9, 9, 9, 9]


# a negative size is the caller's error, so it must not surface as an internal error
query error DataFusion error: Execution error: array_resize: size must not be negative, got \-1
select array_resize(make_array(1, 2, 3), -1, 0);

query error DataFusion error: Execution error: array_resize: size must not be negative, got \-9223372036854775808
select array_resize(make_array(1, 2, 3), -9223372036854775808, 0);

query error DataFusion error: Execution error: array_resize: size must not be negative, got \-1
select array_resize(arrow_cast(make_array(1, 2, 3), 'LargeList(Int64)'), -1, 0);


include ./cleanup.slt.part
Loading