Support dotted field access on struct lambda parameters in SQL exprs - #25177
Draft
shehab-ali wants to merge 1 commit into
Draft
Support dotted field access on struct lambda parameters in SQL exprs#25177shehab-ali wants to merge 1 commit into
shehab-ali wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25177 +/- ##
========================================
Coverage 81.90% 81.90%
========================================
Files 1132 1132
Lines 420155 420590 +435
Branches 420155 420590 +435
========================================
+ Hits 344126 344499 +373
- Misses 55742 55771 +29
- Partials 20287 20320 +33 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Struct-valued lambda parameters cannot currently be accessed using dotted field syntax. For example, the following query fails because
record.rule_actionis resolved as a table-qualified column instead of field access on the lambda parameter:What changes are included in this PR?
When a compound identifier begins with an active lambda parameter, resolve the root as a lambda variable and plan each remaining identifier as named struct-field access.
This supports expressions such as:
Field access is planned through the configured expression planners, consistent with existing field-access handling.
What is the testing strategy for this PR?
Added sqllogictest coverage in array/array_transform.slt for:
Are there any user-facing changes?
no