test: add IN list slt coverage for temporal, Decimal128 and Interval types#23875
Draft
alamb wants to merge 1 commit into
Draft
test: add IN list slt coverage for temporal, Decimal128 and Interval types#23875alamb wants to merge 1 commit into
alamb wants to merge 1 commit into
Conversation
…types Part of apache#23307. Adds sqllogictest coverage for IN lists over Date32, Date64, Time32, Time64, Timestamp (with and without a timezone), Duration, Decimal128 and Interval(MonthDayNano), none of which had any SQL level coverage. Also adds a 17 element Int8/UInt8 list and a 9 element Float16 list so the bitmap specialization stays covered as shorter lists gain their own specializations. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23875 +/- ##
==========================================
- Coverage 80.70% 80.69% -0.01%
==========================================
Files 1090 1090
Lines 370336 370336
Branches 370336 370336
==========================================
- Hits 298873 298859 -14
- Misses 53648 53658 +10
- Partials 17815 17819 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
IN lists over temporal,
Decimal128andIntervalcolumns had no SQL level coverage at all, and the specializations being added in #23014 route those types onto new code paths.What changes are included in this PR?
Adds
in_list.sltcoverage forDate32,Date64,Time32(Second),Time64(Nanosecond),Timestamp(Nanosecond, None),Timestamp(Second, "UTC"),Duration(Second),Decimal128andInterval(MonthDayNano)— coveringIN,NOT IN, NULL bearing lists, short lists reachable only via a NULL element, and (for the 16 byte types) list lengths on either side of the specialization threshold — plus a 17 elementInt8/UInt8list and a 9 elementFloat16list so the bitmap specialization stays covered as shorter lists gain their own specializations.Are these changes tested?
This PR is only tests; they pass on
mainand against the head of #23014.Are there any user-facing changes?
No.