Skip to content

test: Add slt for swapped cross join with conflicting metadata#23857

Open
mkleen wants to merge 1 commit into
apache:mainfrom
mkleen:slt-cross-join-meta
Open

test: Add slt for swapped cross join with conflicting metadata#23857
mkleen wants to merge 1 commit into
apache:mainfrom
mkleen:slt-cross-join-meta

Conversation

@mkleen

@mkleen mkleen commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

This adds a slt test for #23605 to make sure it works end-to-end.

What changes are included in this PR?

  • Data creation in test_context.rs
  • slt

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions Bot added the sqllogictest SQL Logic Tests (.slt) label Jul 24, 2026
@mkleen

mkleen commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Test fails without #23605. However, this only proves that the cross-join is working now in this case. The same issue could be at a lot of other code parts where two schemas get merged together.

@mkleen
mkleen marked this pull request as ready for review July 24, 2026 10:04
@mkleen mkleen changed the title Add slt for swapped cross join with conflicting metadata test: Add slt for swapped cross join with conflicting metadata Jul 24, 2026
@mkleen
mkleen force-pushed the slt-cross-join-meta branch from 8db6242 to ad64982 Compare July 24, 2026 10:46
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.70%. Comparing base (1c8295c) to head (ad64982).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23857      +/-   ##
==========================================
- Coverage   80.75%   80.70%   -0.05%     
==========================================
  Files        1089     1090       +1     
  Lines      368809   370168    +1359     
  Branches   368809   370168    +1359     
==========================================
+ Hits       297837   298754     +917     
- Misses      53217    53600     +383     
- Partials    17755    17814      +59     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants