bench: add ASOF join benchmarks#23833
Draft
Xuanwo wants to merge 8 commits into
Draft
Conversation
github-actions
Bot
added
documentation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23833 +/- ##
==========================================
- Coverage 80.75% 80.73% -0.03%
==========================================
Files 1089 1091 +2
Lines 368948 370706 +1758
Branches 368948 370706 +1758
==========================================
+ Hits 297952 299295 +1343
- Misses 53237 53539 +302
- Partials 17759 17872 +113 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This is the benchmark layer of the ASOF JOIN stack. It keeps performance
workloads separate from the execution, logical, and SQL implementation reviews.
GitHub shows the cumulative stack because fork branches cannot be selected as
upstream PR bases. The isolated diff for this layer is:
Xuanwo/datafusion@xuanwo/asof-sql...xuanwo/asof-benchmarks
What changes are included in this PR?
dfbench asofcommand with four end-to-end workloads:ordered predecessor, grouped predecessor with optimizer-inserted
sort/repartition, wide payloads, and descending successor matching.
AsOfJoinExec.payloads over pre-sorted inputs.
Are these changes tested?
Yes:
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo run -p datafusion-benchmarks --bin dfbench -- asof --iterations 1cargo bench -p datafusion-physical-plan --bench asof_join --features test_utils -- --quickThe end-to-end smoke run returned the expected 1,000,000, 1,000,000, 250,000,
and 500,000 rows. The Criterion smoke run completed all three payload cases.
These debug/quick timings validate the harness and are not presented as
performance claims.
Are there any user-facing changes?
This adds ASOF workloads to the repository benchmark tooling. It does not change
query semantics or runtime behavior.
This PR should be reviewed and merged after #23830. After its dependencies
squash-merge, this branch will be refreshed from
mainwithout rewriting itspublished history.