feat(physical-expr): port TryCastExpr to try_to_proto / try_from_proto hooks#22637
Closed
koopatroopa787 wants to merge 3 commits into
Closed
feat(physical-expr): port TryCastExpr to try_to_proto / try_from_proto hooks#22637koopatroopa787 wants to merge 3 commits into
koopatroopa787 wants to merge 3 commits into
Conversation
…o hooks Move protobuf serialization/deserialization for TryCastExpr out of the central downcast chains in to_proto.rs and from_proto.rs into dedicated try_to_proto / try_from_proto hooks on TryCastExpr itself, following the pattern established for NotExpr, NegativeExpr, IsNullExpr, IsNotNullExpr, and Literal. Closes apache#22429
github-actions
Bot
added
physical-expr
…mport, fix rustfmt
…tNode PhysicalTryCastNode.arrow_type expects datafusion_proto_models::datafusion_common::ArrowType, not datafusion_proto_models::protobuf::ArrowType (which is a distinct type from a different generated module). Import ArrowType, EmptyMessage, and ArrowTypeEnum from the correct path.
Contributor
Author
|
Closing — #22550 was merged to main which already ports TryCastExpr to try_to_proto/try_from_proto hooks. This PR is now superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #22429
Rationale for this change
TryCastExprserialization/deserialization lived in the central downcast chains into_proto.rsandfrom_proto.rs. This PR moves it into self-containedtry_to_proto/try_from_protohooks onTryCastExpritself, following the pattern established forNotExpr,NegativeExpr,IsNullExpr,IsNotNullExpr, andLiteral.What changes are included in this PR?
datafusion/physical-expr/src/expressions/try_cast.rs#[cfg(feature = "proto")] fn try_to_proto(...)insideimpl PhysicalExpr for TryCastExpr#[cfg(feature = "proto")] impl TryCastExpr { pub fn try_from_proto(...) }proto_testsmodule covering: encode, encode-error propagation, decode, reject-wrong-variant, missing-expr, missing-arrow-type, and decode-error propagationdatafusion/proto/src/physical_plan/to_proto.rsTryCastExprdowncast arm; removedTryCastExprfrom import listdatafusion/proto/src/physical_plan/from_proto.rsExprType::TryCastarm withTryCastExpr::try_from_proto(proto, &decode_ctx)?Are there any user-facing changes?
No. Serialization behaviour is identical; only the code location changed.
🤖 Generated with Claude Code