Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes # (none: prerequisite for apache/datafusion-comet#2706; follow-up to #17779 and #19274).
Rationale for this change
The existing Spark map_from_entries / map_from_arrays UDFs silently kept the last occurrence of a duplicate key, hardcoded to the LAST_WIN branch of Spark's spark.sql.mapKeyDedupPolicy. Spark's default is EXCEPTION, and Spark 4 raises SparkRuntimeException with error class DUPLICATED_MAP_KEY. Without matching the default, downstream engines (e.g. datafusion-comet) have to fall back to Spark even for the common case.
What changes are included in this PR?
No config-option or enum is introduced at this stage. map_from_entries.rs, map_from_arrays.rs, and config.rs are untouched.
Are these changes tested?
Yes. The duplicate-key assertions in sqllogictest/test_files/spark/map/map_from_entries.slt and sqllogictest/test_files/spark/map/map_from_arrays.slt are flipped from positive-result to query error.
Are there any user-facing changes?
Yes, a behavior change: duplicate keys now raise [DUPLICATED_MAP_KEY] under the default policy instead of silently collapsing to the last occurrence. This aligns with Spark's documented default. No new config keys, no API changes.