-
Notifications
You must be signed in to change notification settings - Fork 2k
Snowflake Unparser dialect and UNNEST support #21593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yonatan-sevenai
wants to merge
20
commits into
apache:main
Choose a base branch
from
yonatan-sevenai:feature/snowflake_unparser
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
75cd4d7
fix: preserve subquery structure when unparsing SubqueryAlias over Ag…
yonatan-sevenai 2f8f667
Merge branch 'main' into main
yonatan-sevenai 0d223f9
fix: preserve subquery structure when unparsing SubqueryAlias over Ag…
yonatan-sevenai 42f7f64
Fixes in PR
yonatan-sevenai ae2fdcf
Merge branch 'main' into main
yonatan-sevenai 1667252
Merge branch 'main' into main
yonatan-sevenai ab8acf9
Merge branch 'apache:main' into main
yonatan-sevenai adfec24
Merge remote-tracking branch 'datafusion/main'
yonatan-sevenai 8d95d48
test: define correct expected output for Snowflake FLATTEN unparsing
yonatan-sevenai 6acaa9c
Working on unnest support for snowflake
yonatan-sevenai e701962
Snowflake Dialect
yonatan-sevenai 9321138
fix: Snowflake LATERAL FLATTEN handles SubqueryAlias between Unnest a…
yonatan-sevenai 4cc97c8
Merge remote-tracking branch 'datafusion/main' into feature/snowflake…
yonatan-sevenai 065e111
Snowflake Dialect
yonatan-sevenai 909d8c6
More snowflake dialect fixes for unnest
yonatan-sevenai 54d8a1d
More snowflake dialect fixes for unnes
yonatan-sevenai c083c6c
Quoting fix
yonatan-sevenai 455fc83
Unnest fixes for multi-arguments
yonatan-sevenai 5f1d805
Few more fixes
yonatan-sevenai 8e83e17
Generate unique LATERAL FLATTEN aliases per query
yonatan-sevenai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to use a constant to present the name. Something like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test for the multiple unnest case?