Open
Conversation
AdamGS
reviewed
Mar 4, 2026
Contributor
AdamGS
left a comment
AdamGS
left a comment
There was a problem hiding this comment.
FWIW, we've also found mimalloc making a huge difference on macos, which I assume is a very popular dev environment
related to #20052 [Example run](https://github.com/apache/datafusion/actions/runs/22663392017/job/65688981067): 2X faster (50 min → 25 min)
github-actions
bot
added
the
development-process
comphead
reviewed
Mar 4, 2026
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
Thanks @blaginin however I'm not sure about mimalloc for tests tbh, we do mimalloc for benchmarks, but tests asserts correctness and mem usage for default user environment which is glibc malloc or musl malloc if we speaking for Linux and providing results from another mem allocator as a source of truth, WDYT?
Collaborator
Author
|
hey @comphead! In this pr i change just sqlogictests, and they don't assert mem usage - just correctness. They're pretty high level so I'd be surprised if the allocator interferes in any way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #20052
https://github.com/apache/datafusion/actions/runs/22638279915/job/65619265884
-5-10 minutes