Open
Conversation
Support using 'nanosecond' as a part in the date_part function. If nanosecond is requested then the date_part will return the seconds, and smaller units, scaled to nanoseconds. This is consistent with the behaviour of 'millisecond' and 'microsecond'. In order to accomodate the required range of results, a request for 'nanosecond' will return a 64-bit integer, rather than a 32-bit integer as is returned for everything else (except 'epoch').
github-actions
bot
added
sqllogictest
alamb
approved these changes
Mar 3, 2026
| matches!(part.to_lowercase().as_str(), "epoch") | ||
| } | ||
|
|
||
| fn is_nanosecond(part: &str) -> bool { |
Contributor
There was a problem hiding this comment.
Is it worth adding a note that this is required due to the fact that nanosecond needs a different return type
| let subsecs = as_int32_array(subsecs.as_ref())?; | ||
|
|
||
| // Special case where there are no nulls. | ||
| if subsecs.null_count() == 0 { |
Contributor
There was a problem hiding this comment.
Would it be safer to also check sec.nulls too? It does feel like any nulls in subsecs would also be in secs and vica versa
| 12123456 | ||
|
|
||
| query error DataFusion error: This feature is not implemented: Date part Nanosecond not supported | ||
| query I |
| .zip(subsecs) | ||
| .map(|(secs, subsecs)| { | ||
| secs.map(|secs| { | ||
| let subsecs = subsecs.unwrap_or(0); |
Contributor
There was a problem hiding this comment.
I didn't see any test coverage of nulls 🤔 -- maybe we can add some
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support using 'nanosecond' as a part in the date_part function. If nanosecond is requested then the date_part will return the seconds, and smaller units, scaled to nanoseconds. This is consistent with the behaviour of 'millisecond' and 'microsecond'. In order to accomodate the required range of results, a request for 'nanosecond' will return a 64-bit integer, rather than a 32-bit integer as is returned for everything else (except 'epoch').
Which issue does this PR close?
Rationale for this change
The feature is a) useful & b) documented
What changes are included in this PR?
Are these changes tested?
Yes, some added and modified SLT tests.
Are there any user-facing changes?
Only in as much as the implementation now matches the documentation (for this specific case).