Minor: Add comment explaining rationale to avoid dependencies on functions#20667
Open
alamb wants to merge 1 commit intoapache:mainfrom
Open
Minor: Add comment explaining rationale to avoid dependencies on functions#20667alamb wants to merge 1 commit intoapache:mainfrom
alamb wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Somewhat frequently PRs try and add a dependency (both codewise and logically) to datafusion-functions in the datafusion-optimizer crate
This then gets flagged during code review, which is somewhat frustrating probably for the submitter as they didn't know. This most recently happened here https://github.com/apache/datafusion/pull/20610/changes#r2877698578
Thus let's try and document that attempt in comments
What changes are included in this PR?
Add comments to the relevant Cargo.toml file
Are these changes tested?
N/A
Are there any user-facing changes?
No this is a development process change only