fix: handle Utf8View and LargeUtf8 separators in concat_ws#20361
Open
neilconway wants to merge 1 commit intoapache:mainfrom
Open
fix: handle Utf8View and LargeUtf8 separators in concat_ws#20361neilconway wants to merge 1 commit intoapache:mainfrom
neilconway wants to merge 1 commit intoapache:mainfrom
Conversation
github-actions
bot
added
sqllogictest
concat_ws only handled Utf8 separators; attempting to pass a Utf8View or LargeUtf8 separator would result in a panic or error.
neilconway
force-pushed
the
neilc/concat-ws-string-types
branch
from
c9d3bcf to
b68b354
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
concat_ws only handled Utf8 separators (despite its signature claiming otherwise). Attempting to pass a Utf8View or LargeUtf8 separator would result in a panic or internal error.
What changes are included in this PR?
Are these changes tested?
Yes. Added new test cases.
Note that we can't easily the scalar separator case via SQL, because
simplify_concat_wshappens to cast constant/scalar separators to Utf8. That behavior is dubious and should be changed, but I'll tackle that in a subsequent PR.Are there any user-facing changes?
No, aside from a previously failing query now succeeding.