Fix: SparkAscii nullability to depend on input nullability #19531
+58
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19169
Rationale for this change:
The current implementation of
SparkAsciiUDF uses the defaultis_nullablewhich always returns true. This is incorrect because the output should only be nullable if the input argument is nullable. This change implements proper null propagation behavior by usingreturn_field_from_args.Changes in PR:
return_typetoreturn internal_err!sincereturn_field_from_argsis now used (following the pattern used by other Spark functions like ilike, concat, elt)Test Coverage:
Yes, tests are included to verify the change.
User-facing Changes:
No user-facing changes.